namespace Symfony\Component\DependencyInjection\Compiler;
-use Symfony\Component\DependencyInjection\Definition;
+use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\Reference;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
/**
* Checks that all references are pointing to a valid service.
*
* @author Johannes M. Schmitt <schmittjoh@gmail.com>
*/
-class CheckExceptionOnInvalidReferenceBehaviorPass implements CompilerPassInterface
+class CheckExceptionOnInvalidReferenceBehaviorPass extends AbstractRecursivePass
{
- private $container;
- private $sourceId;
-
- public function process(ContainerBuilder $container)
+ protected function processValue($value, $isRoot = false)
{
- $this->container = $container;
-
- foreach ($container->getDefinitions() as $id => $definition) {
- $this->sourceId = $id;
- $this->processDefinition($definition);
+ if (!$value instanceof Reference) {
+ return parent::processValue($value, $isRoot);
}
- }
-
- private function processDefinition(Definition $definition)
- {
- $this->processReferences($definition->getArguments());
- $this->processReferences($definition->getMethodCalls());
- $this->processReferences($definition->getProperties());
- }
-
- private function processReferences(array $arguments)
- {
- foreach ($arguments as $argument) {
- if (is_array($argument)) {
- $this->processReferences($argument);
- } elseif ($argument instanceof Definition) {
- $this->processDefinition($argument);
- } elseif ($argument instanceof Reference && ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE === $argument->getInvalidBehavior()) {
- $destId = (string) $argument;
-
- if (!$this->container->has($destId)) {
- throw new ServiceNotFoundException($destId, $this->sourceId);
- }
- }
+ if (ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE === $value->getInvalidBehavior() && !$this->container->has($id = (string) $value)) {
+ throw new ServiceNotFoundException($id, $this->currentId);
}
+ if (ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE === $value->getInvalidBehavior() && $this->container->has($id = (string) $value) && !$this->container->findDefinition($id)->isShared()) {
+ throw new InvalidArgumentException(sprintf('Invalid ignore-on-uninitialized reference found in service "%s": target service "%s" is not shared.', $this->currentId, $id));
+ }
+
+ return $value;
}
}