Updated Drupal to 8.6. This goes with the following updates because it's possible...

[yaffs-website] / web / core / modules / filter / tests / src / Kernel / Plugin / migrate / process / FilterIdTest.php

diff --git a/web/core/modules/filter/tests/src/Kernel/Plugin/migrate/process/FilterIdTest.php b/web/core/modules/filter/tests/src/Kernel/Plugin/migrate/process/FilterIdTest.php
index e18b3a904dd7ac41d3dea49b1a59a486fff47826..f633debad867894db63f4ab827d3d4340ad5419a 100644 (file)
--- a/web/core/modules/filter/tests/src/Kernel/Plugin/migrate/process/FilterIdTest.php
+++ b/web/core/modules/filter/tests/src/Kernel/Plugin/migrate/process/FilterIdTest.php
@@ -37,7 +37,7 @@ class FilterIdTest extends KernelTestBase {
   }
 
   /**
-   * Tests the filter_id plugin.
+   * Tests transformation of filter_id plugin.
    *
    * @param mixed $value
    *   The input value to the plugin.
@@ -47,11 +47,11 @@ class FilterIdTest extends KernelTestBase {
    *   (optional) The invalid plugin ID which is expected to be logged by the
    *   MigrateExecutable object.
    *
-   * @dataProvider testProvider
+   * @dataProvider provideFilters
    *
    * @covers ::transform
    */
-  public function test($value, $expected_value, $invalid_id = NULL) {
+  public function testTransform($value, $expected_value, $invalid_id = NULL) {
     $configuration = [
       'bypass' => TRUE,
       'map' => [
@@ -78,37 +78,34 @@ class FilterIdTest extends KernelTestBase {
   }
 
   /**
-   * The test data provider.
+   * Provides filter ids for testing transformations.
    *
    * @return array
+   *   Formatted as $source_id, $tranformed_id, $invalid_id.
+   *   When $invalid_id is provided the transformation should fail with the
+   *   supplied id.
    */
-  public function testProvider() {
+  public function provideFilters() {
     return [
-      // The filter ID is mapped, and the plugin exists.
-      [
+      'filter ID mapped to plugin that exists' => [
         'foo',
         'filter_html',
       ],
-      // The filter ID isn't mapped, but it's unchanged from the source (i.e.,
-      // it bypasses the static map) and the plugin exists.
-      [
+      'filter ID not mapped but unchanged from the source and the plugin exists' => [
         'filter_html',
         'filter_html',
       ],
-      // The filter ID is mapped, but the plugin does not exist.
-      [
+      'filter ID mapped to plugin that does not exist' => [
         'baz',
         'filter_null',
         'php_code',
       ],
-      // The filter ID isn't mapped, but it's unchanged from the source (i.e.,
-      // it bypasses the static map) but the plugin does not exist.
-      [
+      'filter ID not mapped but unchanged from the source and the plugin does not exist' => [
         'php_code',
         'filter_null',
         'php_code',
       ],
-      [
+      'filter ID set and the plugin does not exist' => [
         ['filter', 1],
         'filter_null',
         'filter:1',