X-Git-Url: http://www.aleph1.co.uk/gitweb/?p=yaffs-website;a=blobdiff_plain;f=web%2Fmodules%2Fcontrib%2Fdrupalmoduleupgrader%2Ftests%2Fsrc%2FUnit%2FPlugin%2FDMU%2FConverter%2FFunctions%2FVariableGetTest.php;fp=web%2Fmodules%2Fcontrib%2Fdrupalmoduleupgrader%2Ftests%2Fsrc%2FUnit%2FPlugin%2FDMU%2FConverter%2FFunctions%2FVariableGetTest.php;h=2c5f69099880a82f55935d77f893a47830f6916b;hp=0000000000000000000000000000000000000000;hb=8acec36f19c470dfcda1ae2336826a782f41874c;hpb=e0411c4e83ba0d079034db83c3f7f55be24a0e35

diff --git a/web/modules/contrib/drupalmoduleupgrader/tests/src/Unit/Plugin/DMU/Converter/Functions/VariableGetTest.php b/web/modules/contrib/drupalmoduleupgrader/tests/src/Unit/Plugin/DMU/Converter/Functions/VariableGetTest.php
new file mode 100644
index 000000000..2c5f69099
--- /dev/null
+++ b/web/modules/contrib/drupalmoduleupgrader/tests/src/Unit/Plugin/DMU/Converter/Functions/VariableGetTest.php
@@ -0,0 +1,83 @@
+<?php
+
+namespace Drupal\Tests\drupalmoduleupgrader\Unit\Plugin\DMU\Converter\Functions;
+
+use Pharborist\Filter;
+use Pharborist\Parser;
+
+/**
+ * @group DMU.Converter.Functions
+ * @covers \Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\Functions\VariableGet
+ */
+class VariableGetTest extends FunctionCallModifierTestBase {
+
+  public function testNonStringKey() {
+    $original = <<<'END'
+<?php
+variable_get($my_var, TRUE);
+END;
+    $expected = <<<'END'
+<?php
+// @FIXME
+// The correct configuration object could not be determined. You'll need to
+// rewrite this call manually.
+variable_get($my_var, TRUE);
+END;
+
+    $snippet = Parser::parseSource($original);
+    $function_call = $snippet->find(Filter::isFunctionCall('variable_get'))->get(0);
+    $rewritten = $this->plugin->rewrite($function_call, $this->target);
+    $this->assertNull($rewritten);
+    $this->assertSame($expected, $snippet->getText());
+  }
+
+  public function testForeignStringKey() {
+    $original = <<<'END'
+<?php
+variable_get('bar_wambooli', TRUE);
+END;
+    $expected = <<<'END'
+<?php
+// @FIXME
+// This looks like another module's variable. You'll need to rewrite this call
+// to ensure that it uses the correct configuration object.
+variable_get('bar_wambooli', TRUE);
+END;
+
+    $snippet = Parser::parseSource($original);
+    $function_call = $snippet->find(Filter::isFunctionCall('variable_get'))->get(0);
+    $rewritten = $this->plugin->rewrite($function_call, $this->target);
+    $this->assertNull($rewritten);
+    $this->assertSame($expected, $snippet->getText());
+  }
+
+  public function testStringKeyAndUnextractableDefaultValue() {
+    $original = <<<'END'
+<?php
+variable_get('foo_wambooli', array());
+END;
+    $expected = <<<'END'
+<?php
+// @FIXME
+// Could not extract the default value because it is either indeterminate, or
+// not scalar. You'll need to provide a default value in
+// config/install/@module.settings.yml and config/schema/@module.schema.yml.
+variable_get('foo_wambooli', array());
+END;
+
+    $snippet = Parser::parseSource($original);
+    $function_call = $snippet->find(Filter::isFunctionCall('variable_get'))->get(0);
+    $rewritten = $this->plugin->rewrite($function_call, $this->target);
+    $this->assertInstanceOf('\Pharborist\Objects\ObjectMethodCallNode', $rewritten);
+    $this->assertEquals('\Drupal::config(\'foo.settings\')->get(\'foo_wambooli\')', $rewritten->getText());
+    $this->assertSame($expected, $snippet->getText());
+  }
+
+  public function testStringKeyAndExtractableDefaultValue() {
+    $function_call = Parser::parseExpression('variable_get("foo_wambooli", 30)');
+    $rewritten = $this->plugin->rewrite($function_call, $this->target);
+    $this->assertInstanceOf('\Pharborist\Objects\ObjectMethodCallNode', $rewritten);
+    $this->assertEquals('\Drupal::config(\'foo.settings\')->get("foo_wambooli")', $rewritten->getText());
+  }
+
+}