projects
/
yaffs2.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
yaffs: Cache object xattrib state.
[yaffs2.git]
/
yaffs_guts.c
diff --git
a/yaffs_guts.c
b/yaffs_guts.c
index 75eeb84cf3d5d23459d9897fa2b1fbc9e5b9c88c..6ea5698b5052dd375e15bceba736a183209587cc 100644
(file)
--- a/
yaffs_guts.c
+++ b/
yaffs_guts.c
@@
-66,7
+66,7
@@
static yaffs_Object *yaffs_CreateNewObject(yaffs_Device *dev, int number,
yaffs_ObjectType type);
yaffs_ObjectType type);
-static int yaffs_ApplyXMod(yaffs_
Device *dev
, char *buffer, yaffs_XAttrMod *xmod);
+static int yaffs_ApplyXMod(yaffs_
Object *obj
, char *buffer, yaffs_XAttrMod *xmod);
static void yaffs_RemoveObjectFromDirectory(yaffs_Object *obj);
static int yaffs_CheckStructures(void);
static void yaffs_RemoveObjectFromDirectory(yaffs_Object *obj);
static int yaffs_CheckStructures(void);
@@
-3112,7
+3112,7
@@
int yaffs_UpdateObjectHeader(yaffs_Object *in, const YCHAR *name, int force,
/* process any xattrib modifications */
if(xmod)
/* process any xattrib modifications */
if(xmod)
- yaffs_ApplyXMod(
dev
, (char *)buffer, xmod);
+ yaffs_ApplyXMod(
in
, (char *)buffer, xmod);
/* Tags */
/* Tags */
@@
-4939,10
+4939,11
@@
static int yaffs_DoXMod(yaffs_Object *obj, int set, const YCHAR *name, const voi
return -ENOSPC;
}
return -ENOSPC;
}
-static int yaffs_ApplyXMod(yaffs_
Device *dev
, char *buffer, yaffs_XAttrMod *xmod)
+static int yaffs_ApplyXMod(yaffs_
Object *obj
, char *buffer, yaffs_XAttrMod *xmod)
{
int retval = 0;
int x_offs = sizeof(yaffs_ObjectHeader);
{
int retval = 0;
int x_offs = sizeof(yaffs_ObjectHeader);
+ yaffs_Device *dev = obj->myDev;
int x_size = dev->nDataBytesPerChunk - sizeof(yaffs_ObjectHeader);
char * x_buffer = buffer + x_offs;
int x_size = dev->nDataBytesPerChunk - sizeof(yaffs_ObjectHeader);
char * x_buffer = buffer + x_offs;
@@
-4952,6
+4953,9
@@
static int yaffs_ApplyXMod(yaffs_Device *dev, char *buffer, yaffs_XAttrMod *xmod
else
retval = nval_del(x_buffer, x_size, xmod->name);
else
retval = nval_del(x_buffer, x_size, xmod->name);
+ obj->hasXattr = nval_hasvalues(x_buffer, x_size);
+ obj->xattrKnown = 1;
+
xmod->result = retval;
return retval;
xmod->result = retval;
return retval;
@@
-4973,6
+4977,16
@@
static int yaffs_DoXFetch(yaffs_Object *obj, const YCHAR *name, void *value, int
if(obj->hdrChunk < 1)
return -ENODATA;
if(obj->hdrChunk < 1)
return -ENODATA;
+ /* If we know that the object has no xattribs then don't do all the
+ * reading and parsing.
+ */
+ if(obj->xattrKnown && !obj->hasXattr){
+ if(name)
+ return -ENODATA;
+ else
+ return 0;
+ }
+
buffer = yaffs_GetTempBuffer(dev, __LINE__);
if(!buffer)
return -ENOMEM;
buffer = yaffs_GetTempBuffer(dev, __LINE__);
if(!buffer)
return -ENOMEM;
@@
-4984,6
+4998,11
@@
static int yaffs_DoXFetch(yaffs_Object *obj, const YCHAR *name, void *value, int
else{
x_buffer = buffer + x_offs;
else{
x_buffer = buffer + x_offs;
+ if (!obj->xattrKnown){
+ obj->hasXattr = nval_hasvalues(x_buffer, x_size);
+ obj->xattrKnown = 1;
+ }
+
if(name)
retval = nval_get(x_buffer, x_size, name, value, size);
else
if(name)
retval = nval_get(x_buffer, x_size, name, value, size);
else