X-Git-Url: http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=blobdiff_plain;f=direct%2Ftimothy_tests%2Fquick_tests%2Ftest_yaffs_open_EINVAL2.c;h=a0d86e296b89a6640f7eed0729fc0dcf78e6a388;hp=cdab7762ca1e0172174a32ca39a9cb79f5f299d8;hb=716faf42637fc29ca3d2510d8a47fb2516f794e1;hpb=a8fba94306bc6fcaf7d546a3276c12a168ed6261

diff --git a/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL2.c b/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL2.c
index cdab776..a0d86e2 100644
--- a/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL2.c
+++ b/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL2.c
@@ -11,37 +11,32 @@
  * published by the Free Software Foundation.
  */
 
+/* yaffs will open a file without an error with the creation mode set to 255.*/
+
 #include "test_yaffs_open_EINVAL2.h"
 
-static int handle=0;
-int test_yaffs_open_EINVAL2(void){
-	int output=0;
-	int error_code=0;
-	/*printf("path %s\n",path); */
+static int handle = -1;
+
+int test_yaffs_open_EINVAL2(void)
+{
+
 	handle=yaffs_open(FILE_PATH, O_CREAT | O_RDWR ,255);
-	if (handle==-1){
-		error_code=yaffs_get_error();
-		//printf("EEXIST def %d, Error code %d\n",(- EEXIST),error_code);
-		if (abs(error_code)== EINVAL){
-			return 1;
-		}
-		else {
-			printf("different error than expected\n");
-			return -1;
-		}
-	}
-	else {
-		printf(" file opened with bad mode.(which is a bad thing)\n");
+
+	/* yaffs_open does not check the modes passed into it. This means that the file should open */
+	if (handle < 0){
+		print_message("file not opened with bad creation mode set (which is a bad thing)\n",2);
 		return -1;
+	} else {
+		/* file opened */
+		return 1;
 	}
-	/* the program should not get here but the compiler is complaining */
-	return -1;
 }
-int test_yaffs_open_EINVAL2_clean(void){
-	if (handle >=0){
+
+int test_yaffs_open_EINVAL2_clean(void)
+{
+	if (handle >= 0){
 		return yaffs_close(handle);
-	}
-	else {
+	} else {
 		return 1;	/* the file failed to open so there is no need to close it*/
 	}
 }