X-Git-Url: http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=blobdiff_plain;f=direct%2Fyaffsfs.c;h=0b151a2793b4d3fa2bf1d082c57dec4678767721;hp=6622536c834e652826445ada9c76cc0cae764659;hb=844e250e5a2220f99a37ed520d2421736961e96f;hpb=6ec15829a2deee7512bce78387547393585c5dd2

diff --git a/direct/yaffsfs.c b/direct/yaffsfs.c
index 6622536..0b151a2 100644
--- a/direct/yaffsfs.c
+++ b/direct/yaffsfs.c
@@ -34,7 +34,8 @@
 static struct yaffs_obj *yaffsfs_FindObject(struct yaffs_obj *relativeDirectory,
 			const YCHAR *path,
 			int symDepth, int getEquiv,
-			struct yaffs_obj **dirOut);
+			struct yaffs_obj **dirOut,
+			int *notDir);
 
 static void yaffsfs_RemoveObjectCallback(struct yaffs_obj *obj);
 
@@ -211,8 +212,10 @@ static void yaffsfs_PutInode(int inodeId)
 	if(inodeId >= 0 && inodeId < YAFFSFS_N_HANDLES){
 		yaffsfs_Inode *in = & yaffsfs_inode[inodeId];
 		in->count--;
-		if(in->count <= 0)
+		if(in->count <= 0){
 			yaffsfs_ReleaseInode(in);
+			in->count = 0;
+		}
 	}	
 }
 
@@ -277,15 +280,19 @@ static int yaffsfs_PutHandle(int handle)
 	return 0;
 }
 
-static void yaffsfs_PutDeviceHandles(struct yaffs_dev *dev)
+static void yaffsfs_BreakDeviceHandles(struct yaffs_dev *dev)
 {
-	yaffsfs_Handle *yh;
+	yaffsfs_Handle *h;
+	struct yaffs_obj *obj;
 	int i;
 	for(i = 0; i < YAFFSFS_N_HANDLES; i++){
-		yh = & yaffsfs_handle[i];
-		if(yh->useCount>0 && 
-			yaffsfs_inode[yh->inodeId].iObj->my_dev == dev)
-			yaffsfs_PutHandle(i);
+		h = yaffsfs_GetHandlePointer(i);
+		obj = yaffsfs_GetHandleObject(i);
+		if(h && h->useCount>0 && obj && obj->my_dev == dev){
+			h->useCount = 0;
+			yaffsfs_PutInode(h->inodeId);
+			h->inodeId = -1;
+		}
 	}
 }
 
@@ -413,6 +420,22 @@ static struct yaffs_dev *yaffsfs_FindDevice(const YCHAR *path, YCHAR **restOfPat
 	return retval;
 }
 
+static int yaffsfs_CheckPath(const YCHAR *path)
+{
+	int n=0;
+	int divs=0;
+	while(*path && n < YAFFS_MAX_NAME_LENGTH && divs < 100){
+		if(yaffsfs_IsPathDivider(*path)){
+			n=0;
+			divs++;
+		} else
+			n++;
+		path++;
+	}
+	
+	return (*path) ? -1 : 0;
+}
+
 /* FindMountPoint only returns a dev entry if the path is a mount point */
 static struct yaffs_dev *yaffsfs_FindMountPoint(const YCHAR *path)
 {
@@ -447,10 +470,10 @@ static struct yaffs_obj *yaffsfs_FollowLink(struct yaffs_obj *obj,int symDepth)
 
 		if(yaffsfs_IsPathDivider(*alias))
 			/* Starts with a /, need to scan from root up */
-			obj = yaffsfs_FindObject(NULL,alias,symDepth++,1,NULL);
+			obj = yaffsfs_FindObject(NULL,alias,symDepth++,1,NULL,NULL);
 		else
 			/* Relative to here, so use the parent of the symlink as a start */
-			obj = yaffsfs_FindObject(obj->parent,alias,symDepth++,1,NULL);
+			obj = yaffsfs_FindObject(obj->parent,alias,symDepth++,1,NULL,NULL);
 	}
 	return obj;
 }
@@ -463,13 +486,17 @@ static struct yaffs_obj *yaffsfs_FollowLink(struct yaffs_obj *obj,int symDepth)
  * eg. "/data/xx/ff" --> puts name="ff" and returns the directory "/data/xx"
  */
 static struct yaffs_obj *yaffsfs_DoFindDirectory(struct yaffs_obj *startDir,
-				const YCHAR *path, YCHAR **name, int symDepth)
+				const YCHAR *path, YCHAR **name, int symDepth,
+				int *notDir)
 {
 	struct yaffs_obj *dir;
 	YCHAR *restOfPath;
 	YCHAR str[YAFFS_MAX_NAME_LENGTH+1];
 	int i;
 
+	if(notDir)
+		*notDir = 0;
+
 	if(symDepth > YAFFSFS_MAX_SYMLINK_DEREFERENCES)
 		return NULL;
 
@@ -480,6 +507,7 @@ static struct yaffs_obj *yaffsfs_DoFindDirectory(struct yaffs_obj *startDir,
 	else
 		dir = yaffsfs_FindRoot(path,&restOfPath);
 
+
 	while(dir){
 		/*
 		 * parse off /.
@@ -516,8 +544,13 @@ static struct yaffs_obj *yaffsfs_DoFindDirectory(struct yaffs_obj *startDir,
 
 				dir = yaffsfs_FollowLink(dir,symDepth);
 
-				if(dir && dir->variant_type != YAFFS_OBJECT_TYPE_DIRECTORY)
+				if(dir && dir->variant_type != 
+					YAFFS_OBJECT_TYPE_DIRECTORY){
+					if(notDir)
+						*notDir = 1;
 					dir = NULL;
+				}
+				
 			}
 		}
 	}
@@ -525,10 +558,13 @@ static struct yaffs_obj *yaffsfs_DoFindDirectory(struct yaffs_obj *startDir,
 	return NULL;
 }
 
-static struct yaffs_obj *yaffsfs_FindDirectory(struct yaffs_obj *relativeDirectory,
-					const YCHAR *path,YCHAR **name,int symDepth)
+static struct yaffs_obj *yaffsfs_FindDirectory(struct yaffs_obj *relDirectory,
+					const YCHAR *path,
+					YCHAR **name,
+					int symDepth,
+					int *notDir)
 {
-	return yaffsfs_DoFindDirectory(relativeDirectory,path,name,symDepth);
+	return yaffsfs_DoFindDirectory(relDirectory,path,name,symDepth,notDir);
 }
 
 /*
@@ -536,13 +572,13 @@ static struct yaffs_obj *yaffsfs_FindDirectory(struct yaffs_obj *relativeDirecto
  */
 static struct yaffs_obj *yaffsfs_FindObject(struct yaffs_obj *relativeDirectory,
 			const YCHAR *path,int symDepth, int getEquiv,
-			struct yaffs_obj **dirOut)
+			struct yaffs_obj **dirOut, int *notDir)
 {
 	struct yaffs_obj *dir;
 	struct yaffs_obj *obj;
 	YCHAR *name;
 
-	dir = yaffsfs_FindDirectory(relativeDirectory,path,&name,symDepth);
+	dir = yaffsfs_FindDirectory(relativeDirectory,path,&name,symDepth,notDir);
 
 	if(dirOut)
 		*dirOut =  dir;
@@ -609,6 +645,11 @@ int yaffs_open_sharing(const YCHAR *path, int oflag, int mode, int sharing)
 	u8 readRequested;
 	u8 writeRequested;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	/* O_EXCL only has meaning if O_CREAT is specified */
 	if(!(oflag & O_CREAT))
 		oflag &= ~(O_EXCL);
@@ -636,7 +677,7 @@ int yaffs_open_sharing(const YCHAR *path, int oflag, int mode, int sharing)
 		yh = yaffsfs_GetHandlePointer(handle);
 
 		/* try to find the exisiting object */
-		obj = yaffsfs_FindObject(NULL,path,0,1,NULL);
+		obj = yaffsfs_FindObject(NULL,path,0,1,NULL,NULL);
 
 		obj = yaffsfs_FollowLink(obj,symDepth++);
 
@@ -721,7 +762,7 @@ int yaffs_open_sharing(const YCHAR *path, int oflag, int mode, int sharing)
 		 * the directory exists. If not, error.
 		 */
 		if(!obj && !errorReported){
-			dir = yaffsfs_FindDirectory(NULL,path,&name,0);
+			dir = yaffsfs_FindDirectory(NULL,path,&name,0,NULL);
 			if(!dir){
 				yaffsfs_SetError(-ENOTDIR);
 				errorReported = 1;
@@ -860,6 +901,7 @@ int yaffsfs_do_read(int fd, void *vbuf, unsigned int nbyte, int isPread, int off
 	struct yaffs_obj *obj = NULL;
 	int pos = 0;
 	int startPos = 0;
+	int endPos = 0;
 	int nRead = 0;
 	int nToRead = 0;
 	int totalRead = 0;
@@ -878,6 +920,9 @@ int yaffsfs_do_read(int fd, void *vbuf, unsigned int nbyte, int isPread, int off
 		/* Not a reading handle */
 		yaffsfs_SetError(-EINVAL);
 		totalRead = -1;
+	} else if(nbyte > YAFFS_MAX_FILE_SIZE){
+		yaffsfs_SetError(-EINVAL);
+		totalRead = -1;
 	} else {
 		if(isPread)
 			startPos = offset;
@@ -897,6 +942,15 @@ int yaffsfs_do_read(int fd, void *vbuf, unsigned int nbyte, int isPread, int off
 
 		yaffsfs_GetHandle(fd);
 
+		endPos = pos + nbyte;
+
+		if(pos < 0 || pos > YAFFS_MAX_FILE_SIZE ||
+			nbyte > YAFFS_MAX_FILE_SIZE ||
+			endPos < 0 || endPos > YAFFS_MAX_FILE_SIZE){
+			totalRead = -1;
+			nbyte = 0;
+		}
+
 		while(nbyte > 0) {
 			nToRead = YAFFSFS_RW_SIZE - (pos & (YAFFSFS_RW_SIZE -1));
 			if(nToRead > nbyte)
@@ -936,9 +990,8 @@ int yaffsfs_do_read(int fd, void *vbuf, unsigned int nbyte, int isPread, int off
 		if(!isPread) {
 			if(totalRead >= 0)
 				h->position = startPos + totalRead;
-			else {
-					/* todo error */
-			}
+			else
+				yaffsfs_SetError(-EINVAL);
 		}
 
 	}
@@ -965,6 +1018,7 @@ int yaffsfs_do_write(int fd, const void *vbuf, unsigned int nbyte, int isPwrite,
 	struct yaffs_obj *obj = NULL;
 	int pos = 0;
 	int startPos = 0;
+	int endPos;
 	int nWritten = 0;
 	int totalWritten = 0;
 	int write_trhrough = 0;
@@ -992,6 +1046,15 @@ int yaffsfs_do_write(int fd, const void *vbuf, unsigned int nbyte, int isPwrite,
 
 		yaffsfs_GetHandle(fd);
 		pos = startPos;
+		endPos = pos + nbyte;
+
+		if(pos < 0 || pos > YAFFS_MAX_FILE_SIZE ||
+			nbyte > YAFFS_MAX_FILE_SIZE ||
+			endPos < 0 || endPos > YAFFS_MAX_FILE_SIZE){
+			totalWritten = -1;
+			nbyte = 0;
+		}
+
 		while(nbyte > 0) {
 
 			nToWrite = YAFFSFS_RW_SIZE - (pos & (YAFFSFS_RW_SIZE -1));
@@ -1035,9 +1098,8 @@ int yaffsfs_do_write(int fd, const void *vbuf, unsigned int nbyte, int isPwrite,
 		if(!isPwrite){
 			if(totalWritten > 0)
 				h->position = startPos + totalWritten;
-			else {
-				/* todo error */
-			}
+			else
+				yaffsfs_SetError(-EINVAL);
 		}
 	}
 
@@ -1062,14 +1124,20 @@ int yaffs_truncate(const YCHAR *path,off_t new_size)
 	struct yaffs_obj *obj = NULL;
 	struct yaffs_obj *dir = NULL;
 	int result = YAFFS_FAIL;
+	int notDir;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1,&dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1,&dir,&notDir);
 
-	if(!dir)
+	if(!dir && notDir)
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj)
+	else if(!dir || !obj)
 		yaffsfs_SetError(-ENOENT);
 	else if(obj->variant_type != YAFFS_OBJECT_TYPE_FILE)
 		yaffsfs_SetError(-EISDIR);
@@ -1122,10 +1190,11 @@ off_t yaffs_lseek(int fd, off_t offset, int whence)
 	h = yaffsfs_GetHandlePointer(fd);
 	obj = yaffsfs_GetHandleObject(fd);
 
-	if(!h || !obj){
-		/* bad handle */
+	if(!h || !obj)
 		yaffsfs_SetError(-EBADF);
-	} else {
+	else if(offset > YAFFS_MAX_FILE_SIZE)
+		yaffsfs_SetError(-EINVAL);
+	else {
 		if(whence == SEEK_SET){
 			if(offset >= 0)
 				pos = offset;
@@ -1138,10 +1207,12 @@ off_t yaffs_lseek(int fd, off_t offset, int whence)
 				pos = fSize + offset;
 		} 
 
-		if(pos >= 0)
+		if(pos >= 0 && pos <= YAFFS_MAX_FILE_SIZE)
 			h->position = pos;
-		else
+		else{
 			yaffsfs_SetError(-EINVAL);
+			pos = -1;
+		}
 	}
 
 	yaffsfs_Unlock();
@@ -1156,15 +1227,21 @@ int yaffsfs_DoUnlink(const YCHAR *path,int isDirectory)
 	struct yaffs_obj *obj = NULL;
 	YCHAR *name;
 	int result = YAFFS_FAIL;
+	int notDir;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,0,NULL);
-	dir = yaffsfs_FindDirectory(NULL,path,&name,0);
+	obj = yaffsfs_FindObject(NULL,path,0,0,NULL,NULL);
+	dir = yaffsfs_FindDirectory(NULL,path,&name,0,&notDir);
 
-	if(!dir)
+	if(!dir && notDir)
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj)
+	else if(!dir || !obj)
 		yaffsfs_SetError(-ENOENT);
 	else if(obj->my_dev->read_only)
 		yaffsfs_SetError(-EINVAL);
@@ -1181,17 +1258,10 @@ int yaffsfs_DoUnlink(const YCHAR *path,int isDirectory)
 
 	yaffsfs_Unlock();
 
-	/* todo error */
-
 	return (result == YAFFS_FAIL) ? -1 : 0;
 }
 
 
-int yaffs_rmdir(const YCHAR *path)
-{
-	return yaffsfs_DoUnlink(path,1);
-}
-
 int yaffs_unlink(const YCHAR *path)
 {
 	return yaffsfs_DoUnlink(path,0);
@@ -1206,17 +1276,24 @@ int yaffs_rename(const YCHAR *oldPath, const YCHAR *newPath)
 	YCHAR *newname;
 	int result= YAFFS_FAIL;
 	int rename_allowed = 1;
+	int notOldDir;
+	int notNewDir;
 
 	yaffsfs_Lock();
 
-	olddir = yaffsfs_FindDirectory(NULL,oldPath,&oldname,0);
-	newdir = yaffsfs_FindDirectory(NULL,newPath,&newname,0);
-	obj = yaffsfs_FindObject(NULL,oldPath,0,0,NULL);
+	if(yaffsfs_CheckPath(newPath) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
+	olddir = yaffsfs_FindDirectory(NULL,oldPath,&oldname,0,&notOldDir);
+	newdir = yaffsfs_FindDirectory(NULL,newPath,&newname,0,&notNewDir);
+	obj = yaffsfs_FindObject(NULL,oldPath,0,0,NULL,NULL);
 
-	if(!olddir || !newdir) {
+	if((!olddir && notOldDir) || (!newdir && notNewDir)) {
 		yaffsfs_SetError(-ENOTDIR);
 		rename_allowed = 0;
-	} else if(!obj) {
+	} else if(!olddir || !newdir || !obj) {
 		yaffsfs_SetError(-ENOENT);
 		rename_allowed = 0;
 	} else if(obj->my_dev->read_only){
@@ -1299,19 +1376,24 @@ static int yaffsfs_DoStatOrLStat(const YCHAR *path, struct yaffs_stat *buf,int d
 {
 	struct yaffs_obj *obj=NULL;
 	struct yaffs_obj *dir=NULL;
-
 	int retVal = -1;
+	int notDir;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1,&dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1,&dir,&notDir);
 
 	if(!doLStat && obj)
 		obj = yaffsfs_FollowLink(obj,0);
 
-	if(!dir)
+	if(!dir && notDir)
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj)
+	else if(!dir || !obj)
 		yaffsfs_SetError(-ENOENT);
 	else
 		retVal = yaffsfs_DoStat(obj,buf);
@@ -1360,19 +1442,25 @@ static int yaffs_do_setxattr(const YCHAR *path, const char *name, const void *da
 {
 	struct yaffs_obj *obj;
 	struct yaffs_obj *dir;
+	int notDir;
 
 	int retVal = -1;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1,&dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1,&dir,&notDir);
 
 	if(follow)
 		obj = yaffsfs_FollowLink(obj,0);
 
-	if(!dir) 
+	if(!dir && notDir) 
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj) 
+	else if(!dir || !obj) 
 		yaffsfs_SetError(-ENOENT);
 	else {
 		retVal = yaffs_set_xattrib(obj,name,data,size,flags);
@@ -1428,19 +1516,24 @@ static int yaffs_do_getxattr(const YCHAR *path, const char *name, void *data, in
 {
 	struct yaffs_obj *obj;
 	struct yaffs_obj *dir;
-
 	int retVal = -1;
+	int notDir;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1,&dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1,&dir,&notDir);
 
 	if(follow)
 		obj = yaffsfs_FollowLink(obj,0);
 
-	if(!dir) 
+	if(!dir && notDir) 
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj) 
+	else if(!dir || !obj) 
 		yaffsfs_SetError(-ENOENT);
 	else {
 		retVal = yaffs_get_xattrib(obj,name,data,size);
@@ -1494,19 +1587,24 @@ static int yaffs_do_listxattr(const YCHAR *path, char *data, int size, int follo
 {
 	struct yaffs_obj *obj=NULL;
 	struct yaffs_obj *dir=NULL;
-
 	int retVal = -1;
+	int notDir;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1,&dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1,&dir,&notDir);
 
 	if(follow)
 		obj = yaffsfs_FollowLink(obj,0);
 
-	if(!dir) 
+	if(!dir && notDir) 
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj) 
+	else if(!dir || !obj) 
 		yaffsfs_SetError(-ENOENT);
 	else {
 		retVal = yaffs_list_xattrib(obj, data,size);
@@ -1560,19 +1658,24 @@ static int yaffs_do_removexattr(const YCHAR *path, const char *name, int follow)
 {
 	struct yaffs_obj *obj=NULL;
 	struct yaffs_obj *dir=NULL;
-
+	int notDir;
 	int retVal = -1;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1, &dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1, &dir,&notDir);
 
 	if(follow)
 		obj = yaffsfs_FollowLink(obj,0);
 
-	if(!dir) 
+	if(!dir && notDir) 
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj) 
+	else if(!dir || !obj) 
 		yaffsfs_SetError(-ENOENT);
 	else {
 		retVal = yaffs_remove_xattrib(obj,name);
@@ -1723,9 +1826,14 @@ int yaffs_access(const YCHAR *path, int amode)
 {
 	struct yaffs_obj *obj=NULL;
 	struct yaffs_obj *dir=NULL;
-
+	int notDir;
 	int retval = -1;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	if(amode & ~(R_OK | W_OK | X_OK)){
 		yaffsfs_SetError(-EINVAL);
 		return -1;
@@ -1733,11 +1841,11 @@ int yaffs_access(const YCHAR *path, int amode)
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1, &dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1, &dir,&notDir);
 
-	if(!dir) 
+	if(!dir && notDir) 
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj) 
+	else if(!dir || !obj) 
 		yaffsfs_SetError(-ENOENT);
 	else {
 		int access_ok = 1;
@@ -1767,6 +1875,12 @@ int yaffs_chmod(const YCHAR *path, mode_t mode)
 	struct yaffs_obj *obj=NULL;
 	struct yaffs_obj *dir=NULL;
 	int retVal = -1;
+	int notDir;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
 
 	if(mode & ~(0777)){
 		yaffsfs_SetError(-EINVAL);
@@ -1775,11 +1889,11 @@ int yaffs_chmod(const YCHAR *path, mode_t mode)
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1, &dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1, &dir, &notDir);
 
-	if(!dir) 
+	if(!dir && notDir) 
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj) 
+	else if(!dir || !obj) 
 		yaffsfs_SetError(-ENOENT);
 	else if(obj->my_dev->read_only)
 		yaffsfs_SetError(-EROFS);
@@ -1819,22 +1933,17 @@ int yaffs_fchmod(int fd, mode_t mode)
 }
 
 
-int yaffs_mkdir(const YCHAR *path, mode_t mode)
+static int yaffsfs_alt_dir_path(const YCHAR *path, YCHAR **ret_path)
 {
-	struct yaffs_obj *parent = NULL;
-	struct yaffs_obj *dir = NULL;
-	YCHAR *name;
-	YCHAR *use_path = NULL;
-	int path_length = 0;
-	int retVal= -1;
+	YCHAR *alt_path = NULL;
+	int path_length;
 	int i;
 
-
 	/*
 	 * We don't have a definition for max path length.
 	 * We will use 3 * max name length instead.
 	 */
-	
+	*ret_path = NULL;
 	path_length = strnlen(path,(YAFFS_MAX_NAME_LENGTH+1)*3 +1);
 
 	/* If the last character is a path divider, then we need to
@@ -1845,50 +1954,92 @@ int yaffs_mkdir(const YCHAR *path, mode_t mode)
 	 */
 	if(path_length > 0 && 
 		yaffsfs_IsPathDivider(path[path_length-1])){
-		use_path = YMALLOC(path_length + 1);
-		if(!use_path){
-			yaffsfs_SetError(-ENOMEM);
+		alt_path = YMALLOC(path_length + 1);
+		if(!alt_path)
 			return -1;
-		}
-		strcpy(use_path, path);
+		strcpy(alt_path, path);
 		for(i = path_length-1;
-			i >= 0 && yaffsfs_IsPathDivider(use_path[i]);
+			i >= 0 && yaffsfs_IsPathDivider(alt_path[i]);
 			i--)
-			use_path[i] = (YCHAR) 0;
-		path = use_path;
+			alt_path[i] = (YCHAR) 0;
+	}
+	*ret_path = alt_path;
+	return 0;
+}
+
+int yaffs_mkdir(const YCHAR *path, mode_t mode)
+{
+	struct yaffs_obj *parent = NULL;
+	struct yaffs_obj *dir = NULL;
+	YCHAR *name;
+	YCHAR *alt_path = NULL;
+	int retVal= -1;
+	int notDir;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
 	}
+
+	if(yaffsfs_alt_dir_path(path, &alt_path) < 0){
+		yaffsfs_SetError(-ENOMEM);
+		return -1;
+	}
+	if(alt_path)
+		path = alt_path;
 	
 	yaffsfs_Lock();
-	parent = yaffsfs_FindDirectory(NULL,path,&name,0);
-	if(parent && yaffs_strnlen(name,5) == 0){
+	parent = yaffsfs_FindDirectory(NULL,path,&name,0,&notDir);
+	if(!parent && notDir)
+		yaffsfs_SetError(-ENOTDIR);
+	else if(!parent)
+		yaffsfs_SetError(-ENOENT);
+	else if(yaffs_strnlen(name,5) == 0){
 		/* Trying to make the root itself */
 		yaffsfs_SetError(-EEXIST);
-	} else if(parent && parent->my_dev->read_only){
-		yaffsfs_SetError(-EINVAL);
-	} else {
-		if(parent)
-			dir = yaffs_create_dir(parent,name,mode,0,0);
+	} else if(parent->my_dev->read_only)
+		yaffsfs_SetError(-EROFS);
+	else {
+		dir = yaffs_create_dir(parent,name,mode,0,0);
 		if(dir)
 			retVal = 0;
-		else {
-			if(!parent)
-				yaffsfs_SetError(-ENOENT); /* missing path */
-			else if (yaffs_find_by_name(parent,name))
-				yaffsfs_SetError(-EEXIST); /* the name already exists */
-			else
-				yaffsfs_SetError(-ENOSPC); /* just assume no space */
-			retVal = -1;
-		}
+		else if (yaffs_find_by_name(parent,name))
+			yaffsfs_SetError(-EEXIST); /* the name already exists */
+		else
+			yaffsfs_SetError(-ENOSPC); /* just assume no space */
 	}
 
 	yaffsfs_Unlock();
 
-	if(use_path)
-		YFREE(use_path);
+	if(alt_path)
+		YFREE(alt_path);
 
 	return retVal;
 }
 
+int yaffs_rmdir(const YCHAR *path)
+{
+	int result;
+	YCHAR *alt_path;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
+	if(yaffsfs_alt_dir_path(path, &alt_path) < 0){
+		yaffsfs_SetError(-ENOMEM);
+		return -1;
+	}
+	if(alt_path)
+		path = alt_path;
+	result =  yaffsfs_DoUnlink(path,1);
+	if(alt_path)
+		YFREE(alt_path);
+	return result;
+}
+
+
 void * yaffs_getdev(const YCHAR *path)
 {
 	struct yaffs_dev *dev=NULL;
@@ -1905,6 +2056,11 @@ int yaffs_mount2(const YCHAR *path,int read_only)
 
 	T(YAFFS_TRACE_MOUNT,(TSTR("yaffs: Mounting %s" TENDSTR),path));
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	yaffsfs_Lock();
 
 	yaffsfs_InitHandles();
@@ -1915,16 +2071,13 @@ int yaffs_mount2(const YCHAR *path,int read_only)
 			dev->read_only = read_only ? 1 : 0;
 			result = yaffs_guts_initialise(dev);
 			if(result == YAFFS_FAIL)
-				/* todo error - mount failed */
 				yaffsfs_SetError(-ENOMEM);
 			retVal = result ? 0 : -1;
 
 		}
 		else
-			/* todo error - already mounted. */
 			yaffsfs_SetError(-EBUSY);
 	} else
-		/* todo error - no device */
 		yaffsfs_SetError(-ENODEV);
 
 	yaffsfs_Unlock();
@@ -1942,6 +2095,11 @@ int yaffs_sync(const YCHAR *path)
         int retVal=-1;
         struct yaffs_dev *dev=NULL;
         YCHAR *dummy;
+
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
         
         yaffsfs_Lock();
         dev = yaffsfs_FindDevice(path,&dummy);
@@ -1953,11 +2111,9 @@ int yaffs_sync(const YCHAR *path)
                         retVal = 0;
                         
                 } else
-                        /* todo error - not mounted. */
                         yaffsfs_SetError(-EINVAL);
                         
         }else
-                /* todo error - no device */
                 yaffsfs_SetError(-ENODEV);
 
         yaffsfs_Unlock();
@@ -1971,6 +2127,11 @@ int yaffs_remount(const YCHAR *path, int force, int read_only)
 	struct yaffs_dev *dev=NULL;
 	yaffsfs_Handle *yh;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	yaffsfs_Lock();
 	dev = yaffsfs_FindMountPoint(path);
 	if(dev){
@@ -2012,6 +2173,11 @@ int yaffs_unmount2(const YCHAR *path, int force)
         int retVal=-1;
 	struct yaffs_dev *dev=NULL;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	yaffsfs_Lock();
 	dev = yaffsfs_FindMountPoint(path);
 	if(dev){
@@ -2030,20 +2196,17 @@ int yaffs_unmount2(const YCHAR *path, int force)
 
 			if(!inUse || force){
 				if(inUse)
-					yaffsfs_PutDeviceHandles(dev);
+					yaffsfs_BreakDeviceHandles(dev);
 				yaffs_deinitialise(dev);
 
 				retVal = 0;
 			} else
-				/* todo error can't unmount as files are open */
 				yaffsfs_SetError(-EBUSY);
 
 		} else
-			/* todo error - not mounted. */
 			yaffsfs_SetError(-EINVAL);
 
 	} else
-		/* todo error - no device */
 		yaffsfs_SetError(-ENODEV);
 
 	yaffsfs_Unlock();
@@ -2062,6 +2225,11 @@ loff_t yaffs_freespace(const YCHAR *path)
 	struct yaffs_dev *dev=NULL;
 	YCHAR *dummy;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	yaffsfs_Lock();
 	dev = yaffsfs_FindDevice(path,&dummy);
 	if(dev  && dev->is_mounted){
@@ -2081,10 +2249,16 @@ loff_t yaffs_totalspace(const YCHAR *path)
 	struct yaffs_dev *dev=NULL;
 	YCHAR *dummy;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	yaffsfs_Lock();
 	dev = yaffsfs_FindDevice(path,&dummy);
 	if(dev  && dev->is_mounted){
-		retVal = (dev->param.end_block - dev->param.start_block + 1) - dev->param.n_reserved_blocks;
+		retVal = (dev->param.end_block - dev->param.start_block + 1) - 
+			dev->param.n_reserved_blocks;
 		retVal *= dev->param.chunks_per_block;
 		retVal *= dev->data_bytes_per_chunk;
 
@@ -2101,6 +2275,11 @@ int yaffs_inodecount(const YCHAR *path)
 	struct yaffs_dev *dev=NULL;
 	YCHAR *dummy;
 
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
 	yaffsfs_Lock();
 	dev = yaffsfs_FindDevice(path,&dummy);
 	if(dev  && dev->is_mounted) {
@@ -2230,12 +2409,24 @@ yaffs_DIR *yaffs_opendir(const YCHAR *dirname)
 	yaffs_DIR *dir = NULL;
  	struct yaffs_obj *obj = NULL;
 	yaffsfs_DirectorySearchContext *dsc = NULL;
+	int notDir;
+
+	if(yaffsfs_CheckPath(dirname) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return NULL;
+	}
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,dirname,0,1,NULL);
+	obj = yaffsfs_FindObject(NULL,dirname,0,1,NULL,&notDir);
 
-	if(obj && obj->variant_type == YAFFS_OBJECT_TYPE_DIRECTORY){
+	if(!obj && notDir)
+		yaffsfs_SetError(-ENOTDIR);
+	else if(!obj)
+		yaffsfs_SetError(-ENOENT);
+	else if(obj->variant_type != YAFFS_OBJECT_TYPE_DIRECTORY)
+		yaffsfs_SetError(-ENOTDIR);
+	else {
 
 		dsc = YMALLOC(sizeof(yaffsfs_DirectorySearchContext));
 		dir = (yaffs_DIR *)dsc;
@@ -2329,22 +2520,28 @@ int yaffs_symlink(const YCHAR *oldpath, const YCHAR *newpath)
 	YCHAR *name;
 	int retVal= -1;
 	int mode = 0; /* ignore for now */
+	int notDir;
 
+	if(yaffsfs_CheckPath(newpath) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
 	yaffsfs_Lock();
-	parent = yaffsfs_FindDirectory(NULL,newpath,&name,0);
-	if(parent && parent->my_dev->read_only)
-		yaffsfs_SetError(-EINVAL);
+	parent = yaffsfs_FindDirectory(NULL,newpath,&name,0,&notDir);
+	if(!parent && notDir)
+		yaffsfs_SetError(-ENOTDIR);
+	else if( !parent || yaffs_strnlen(name,5) < 1)
+		yaffsfs_SetError(-ENOENT);
+	else if(parent->my_dev->read_only)
+		yaffsfs_SetError(-EROFS);
 	else if(parent){
 		obj = yaffs_create_symlink(parent,name,mode,0,0,oldpath);
 		if(obj)
 			retVal = 0;
-		else{
-			yaffsfs_SetError(-ENOSPC); /* just assume no space for now */
-			retVal = -1;
-		}
-	} else {
-		yaffsfs_SetError(-EINVAL);
-		retVal = -1;
+		else if (yaffsfs_FindObject(NULL,newpath,0,0, NULL,NULL))
+			yaffsfs_SetError(-EEXIST);
+		else
+			yaffsfs_SetError(-ENOSPC);
 	}
 
 	yaffsfs_Unlock();
@@ -2358,14 +2555,15 @@ int yaffs_readlink(const YCHAR *path, YCHAR *buf, int bufsiz)
 	struct yaffs_obj *obj = NULL;
 	struct yaffs_obj *dir = NULL;
 	int retVal= -1;
+	int notDir;
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,path,0,1, &dir);
+	obj = yaffsfs_FindObject(NULL,path,0,1, &dir,&notDir);
 
-	if(!dir) 
+	if(!dir && notDir) 
 		yaffsfs_SetError(-ENOTDIR);
-	else if(!obj) 
+	else if(!dir || !obj) 
 		yaffsfs_SetError(-ENOENT);
 	else if(obj->variant_type != YAFFS_OBJECT_TYPE_SYMLINK)
 		yaffsfs_SetError(-EINVAL);
@@ -2384,43 +2582,45 @@ int yaffs_link(const YCHAR *oldpath, const YCHAR *linkpath)
 	/* Creates a link called newpath to existing oldpath */
 	struct yaffs_obj *obj = NULL;
 	struct yaffs_obj *lnk = NULL;
+	struct yaffs_obj *obj_dir = NULL;
+	struct yaffs_obj *lnk_dir = NULL;
 	int retVal = -1;
+	int notDirObj;
+	int notDirLnk;
+	YCHAR *newname;
+
+	if(yaffsfs_CheckPath(linkpath) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
 
 	yaffsfs_Lock();
 
-	obj = yaffsfs_FindObject(NULL,oldpath,0,1,NULL);
-	lnk = yaffsfs_FindObject(NULL,linkpath,0,0,NULL);
+	obj = yaffsfs_FindObject(NULL,oldpath,0,1,&obj_dir,&notDirObj);
+	lnk = yaffsfs_FindObject(NULL,linkpath,0,0,NULL,NULL);
+	lnk_dir = yaffsfs_FindDirectory(NULL,linkpath,&newname,0,&notDirLnk);
 
-	if(!obj)
+	if((!obj_dir && notDirObj) || (!lnk_dir && notDirLnk))
+		yaffsfs_SetError(-ENOTDIR);
+	else if(!obj_dir || !lnk_dir || !obj)
 		yaffsfs_SetError(-ENOENT);
 	else if(obj->my_dev->read_only)
 		yaffsfs_SetError(-EINVAL);
 	else if(lnk)
 		yaffsfs_SetError(-EEXIST);
-	else {
-		struct yaffs_obj *newdir = NULL;
-		struct yaffs_obj *link = NULL;
-
-		YCHAR *newname;
-
-		newdir = yaffsfs_FindDirectory(NULL,linkpath,&newname,0);
-
-		if(!newdir)
-			yaffsfs_SetError(-ENOTDIR);
-		else if(newdir->my_dev != obj->my_dev)
-			yaffsfs_SetError(-EXDEV);
-		
+	else if(lnk_dir->my_dev != obj->my_dev)
+		yaffsfs_SetError(-EXDEV);
+	else {		
 		retVal = yaffsfs_CheckNameLength(newname);
 		
 		if(retVal == 0) {
-			link = yaffs_link_obj(newdir,newname,obj);
-			if(link)
+			lnk = yaffs_link_obj(lnk_dir,newname,obj);
+			if(lnk)
 				retVal = 0;
 			else{
 				yaffsfs_SetError(-ENOSPC);
 				retVal = -1;
 			}
-
 		}
 	}
 	yaffsfs_Unlock();
@@ -2433,11 +2633,16 @@ int yaffs_mknod(const YCHAR *pathname, mode_t mode, dev_t dev)
 	pathname=pathname;
 	mode=mode;
 	dev=dev;
+
+	yaffsfs_SetError(-EINVAL);
 	return -1;
 }
 
 
-
+/*
+ * D E B U G   F U N C T I O N S
+ */
+ 
 /*
  * yaffs_n_handles()
  * Returns number of handles attached to the object
@@ -2446,9 +2651,17 @@ int yaffs_n_handles(const YCHAR *path)
 {
 	struct yaffs_obj *obj;
 
-	obj = yaffsfs_FindObject(NULL,path,0,1,NULL);
+	if(yaffsfs_CheckPath(path) < 0){
+		yaffsfs_SetError(-ENAMETOOLONG);
+		return -1;
+	}
+
+	obj = yaffsfs_FindObject(NULL,path,0,1,NULL,NULL);
 
-	return yaffsfs_CountHandles(obj);
+	if(obj)
+		return yaffsfs_CountHandles(obj);
+	else
+		return -1;
 }
 
 int yaffs_get_error(void)
@@ -2458,7 +2671,6 @@ int yaffs_get_error(void)
 
 int yaffs_set_error(int error)
 {
-	/*yaffsfs_SetError does not return. So the program is assumed to have worked. */
 	yaffsfs_SetError(error);
 	return 0;
 }