From: luc Date: Tue, 2 Aug 2005 19:18:44 +0000 (+0000) Subject: Check the return value of mtd->write_ecc() calls. X-Git-Tag: pre-name-change~421 X-Git-Url: http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=commitdiff_plain;h=0128ef2c964bf34556e8f683851a4d2d5e7cf3b3 Check the return value of mtd->write_ecc() calls. If not done, write failures will not be detected. Thanks to Artis Kugevics. --- diff --git a/yaffs_mtdif.c b/yaffs_mtdif.c index 5d1777e..9537b1a 100644 --- a/yaffs_mtdif.c +++ b/yaffs_mtdif.c @@ -13,7 +13,7 @@ * */ -const char *yaffs_mtdif_c_version = "$Id: yaffs_mtdif.c,v 1.8 2005-08-02 19:17:55 luc Exp $"; +const char *yaffs_mtdif_c_version = "$Id: yaffs_mtdif.c,v 1.9 2005-08-02 19:18:44 luc Exp $"; #include "yportenv.h" @@ -52,9 +52,9 @@ int nandmtd_WriteChunkToNAND(yaffs_Device *dev,int chunkInNAND,const __u8 *data, if(data && spare) { if(dev->useNANDECC) - mtd->write_ecc(mtd,addr,dev->nBytesPerChunk,&dummy,data,spareAsBytes,&yaffs_oobinfo); + retval = mtd->write_ecc(mtd,addr,dev->nBytesPerChunk,&dummy,data,spareAsBytes,&yaffs_oobinfo); else - mtd->write_ecc(mtd,addr,dev->nBytesPerChunk,&dummy,data,spareAsBytes,&yaffs_noeccinfo); + retval = mtd->write_ecc(mtd,addr,dev->nBytesPerChunk,&dummy,data,spareAsBytes,&yaffs_noeccinfo); } else {