From: Timothy Manning <tfhmanning@gmail.com>
Date: Tue, 9 Nov 2010 01:00:32 +0000 (+1300)
Subject: yaffs More quick tests and have also fixed a bugin yaffs_mount function.
X-Git-Tag: linux-mainline-patchset-4~106
X-Git-Url: http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=commitdiff_plain;h=24c7a59d54dbe6946be101db3c8ae38f92634129

yaffs More quick tests and have also fixed a bugin yaffs_mount function.
Signed-off-by: Timothy Manning <tfhmanning@gmail.com>
---

diff --git a/direct/timothy_tests/quick_tests/Makefile b/direct/timothy_tests/quick_tests/Makefile
index cb13baa..07b2948 100644
--- a/direct/timothy_tests/quick_tests/Makefile
+++ b/direct/timothy_tests/quick_tests/Makefile
@@ -18,7 +18,7 @@
 
 #EXTRA_COMPILE_FLAGS = -DYAFFS_IGNORE_TAGS_ECC
 
-CFLAGS =      -DCONFIG_YAFFS_DIRECT -DCONFIG_YAFFS_SHORT_NAMES_IN_RAM -DCONFIG_YAFFS_YAFFS2  
+CFLAGS =      -DCONFIG_YAFFS_DIRECT -DCONFIG_YAFFS_YAFFS2  
 CFLAGS +=     -DCONFIG_YAFFS_PROVIDE_DEFS -DCONFIG_YAFFSFS_PROVIDE_VALUES
 CFLAGS +=    -Wall -g $(EXTRA_COMPILE_FLAGS) -Wstrict-aliasing 
 #CFLAGS +=    -fno-strict-aliasing
diff --git a/direct/timothy_tests/quick_tests/current_bugs.txt b/direct/timothy_tests/quick_tests/current_bugs.txt
index be27d78..da09048 100644
--- a/direct/timothy_tests/quick_tests/current_bugs.txt
+++ b/direct/timothy_tests/quick_tests/current_bugs.txt
@@ -3,31 +3,29 @@ Made by Timothy Manning <timothy@yaffs.net> on 08/11/2010
 
 
 Current BUGS 
-	Bug with opening a file with a name of 1,000,000 char long with no errors.
 
-	Bug with unlinking a file with 1,000,000 get the error ENOENT but should
-	be geting ENAMETOOLONG. 
+	NAME SIZE
+		Bug with opening a file with a name of 1,000,000 char long with no errors.
+		The open function should be returning ENAMETOOLONG.
 
-	Bug with mounting a too long non-existant mount point is returning 
-	ENODEV. there are two errors here, ENOENT and ENAMETOOLONG.
-	The ENODEV is the error which yaffs gives instead of ENOENT.
-	BBut the mount function should just return ENAMETOOLONG.
+		Bug with unlinking a file with 1,000,000 get the error ENOENT but should
+		be geting ENAMETOOLONG. 
 
-	Bug when trying to use yaffs_access on an existing file with mode 255 
-	the error returned is EACCES it should be EINVAL(note there is no quick test file yet).
+		Bug with mounting a too long non-existant mount point is returning 
+		ENODEV. yaffs_mount should be returning ENAMETOOLONG.
+		When the name is passed into the yaffs_mount function the length of the
+		mount point decreases from around 10000000 to 200. This needs to be investigated.
 
-	Bug when trying to access a non-existing directory the error ENOENT is 
-	returned. It should be ENOTDIR.
 
-	Bug when trying to truncate a file in a non-existing directory. The error
-	returned is ENOENT it should be ENOTDIR.
+	ENOTDIR ERRORS
+		Bug when trying to access a non-existing directory the error ENOENT is 
+		returned. It should be ENOTDIR.
 
-	Bug truncating a file to a size of -1 does not cause an error. 
+		Bug when trying to truncate a file in a non-existing directory. The error
+		returned is ENOENT it should be ENOTDIR.
 
-	
-	Bug with opening a file with bad mode. yaffs_open has two modes which 
-	are passed into it. if the modes are set to 255 the open function 
-	does not report any errors. (Also need to try this with modes set to -1.)  
+	Bug with truncating to a very large size. The yaffs_truncate function truncates the file to a massive size without any errors.
+	The function should return the error EINVAL. 
 
 	Bug with lseeking to a very large size (size =100000000000000000000000000000000000000) without causing an error.
 	Should cause the error EINVAL.
@@ -35,12 +33,18 @@ Current BUGS
 
 Current WARNINGS
 	
-	WARNING- truncating a file to a size greater than the maximum file size returns
-	EINVAL. In standard linux system the error EFBIG is returned. 
-	
+	<<WHAT FUNCTIONS>>
 	WARNING- If yaffs is unmounted then most of yaffs' functions return ENODIR. 
 	some function return EBADF instead.
 
+	WARNING-the function yaffs_open does not check the mode passed to it. 
+	This means that yaffs open does not return EINVAL if a bad mode is passed to it.
+	However this causes the error EEXIST to happen instead, because both O_CREAT and O_EXCL  flags are set.
+
+	WARNING- yaffs_open will work with either of the two mode set to 255.
+	However there are only 4 or 5 flags that can be set for each of the modes.
+	This means that the programmer may not be setting the flags properly.  
+
 	WARNING- When mounting a non-existing mount point the error ENODEV is returned.
 	The quick tests have been altered to accommodate this error code.    
 	With standard access function in linux the error returned is ENOENT.
diff --git a/direct/timothy_tests/quick_tests/quick_tests.h b/direct/timothy_tests/quick_tests/quick_tests.h
index fd75a73..9a0adc2 100644
--- a/direct/timothy_tests/quick_tests/quick_tests.h
+++ b/direct/timothy_tests/quick_tests/quick_tests.h
@@ -91,7 +91,7 @@ typedef struct test {
 test_template test_list[]={
 	{test_yaffs_mount,test_yaffs_mount_clean,"test_yaffs_mount"},
 	{test_yaffs_mount_ENODEV,test_yaffs_mount_ENODEV_clean,"test_yaffs_mount_ENODEV"},
-//	{test_yaffs_mount_ENAMETOOLONG,test_yaffs_mount_ENAMETOOLONG_clean,"test_yaffs_mount_ENAMETOOLONG"},
+	{test_yaffs_mount_ENAMETOOLONG,test_yaffs_mount_ENAMETOOLONG_clean,"test_yaffs_mount_ENAMETOOLONG"},
 	{test_yaffs_mount_ENOENT,test_yaffs_mount_ENOENT_clean,"test_yaffs_mount_ENOENT"},
 	{test_yaffs_mount_EBUSY,test_yaffs_mount_EBUSY_clean,"test_yaffs_mount_EBUSY"},
 
diff --git a/direct/timothy_tests/quick_tests/test_yaffs_mount_ENAMETOOLONG.c b/direct/timothy_tests/quick_tests/test_yaffs_mount_ENAMETOOLONG.c
index 99102c9..da12b1e 100644
--- a/direct/timothy_tests/quick_tests/test_yaffs_mount_ENAMETOOLONG.c
+++ b/direct/timothy_tests/quick_tests/test_yaffs_mount_ENAMETOOLONG.c
@@ -30,8 +30,8 @@ int test_yaffs_mount_ENAMETOOLONG(void){
 		return -1;
 	} 
 
-	strcat(file_name,YAFFS_MOUNT_POINT);
-	for (x=strlen(YAFFS_MOUNT_POINT); x<file_name_length -1; x++){
+
+	for (x=0; x<file_name_length -1; x++){
 		file_name[x]='a';
 	}
 	file_name[file_name_length-2]='\0';
@@ -41,7 +41,7 @@ int test_yaffs_mount_ENAMETOOLONG(void){
 
 	output=yaffs_mount(file_name);
 
-	if (output==-1){
+	if (output<0){
 		error_code=yaffs_get_error();
 		if (abs(error_code)== ENAMETOOLONG){
 			return 1;
diff --git a/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL.c b/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL.c
index 17c5912..3569028 100644
--- a/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL.c
+++ b/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL.c
@@ -21,8 +21,10 @@ int test_yaffs_open_EINVAL(void){
 	handle=yaffs_open(FILE_PATH, 255,FILE_MODE);
 	if (handle==-1){
 		error_code=yaffs_get_error();
-		//printf("EEXIST def %d, Error code %d\n",(- EEXIST),error_code);
-		if (abs(error_code)== EINVAL){
+		if (abs(error_code)== EEXIST){	/* yaffs open does not check the mode. 
+						so yaffs open does not return EINVAL.
+						This causes the error EEXIST to happen instead
+						because both O_CREAT and O_EXCL are set */ 
 			return 1;
 		}
 		else {
diff --git a/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL2.c b/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL2.c
index cdab776..3ea0918 100644
--- a/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL2.c
+++ b/direct/timothy_tests/quick_tests/test_yaffs_open_EINVAL2.c
@@ -11,6 +11,8 @@
  * published by the Free Software Foundation.
  */
 
+/* yaffs will open a file without an error with the creation mode set to 255.*/
+
 #include "test_yaffs_open_EINVAL2.h"
 
 static int handle=0;
@@ -20,22 +22,14 @@ int test_yaffs_open_EINVAL2(void){
 	/*printf("path %s\n",path); */
 	handle=yaffs_open(FILE_PATH, O_CREAT | O_RDWR ,255);
 	if (handle==-1){
-		error_code=yaffs_get_error();
-		//printf("EEXIST def %d, Error code %d\n",(- EEXIST),error_code);
-		if (abs(error_code)== EINVAL){
-			return 1;
-		}
-		else {
-			printf("different error than expected\n");
-			return -1;
-		}
+		printf("file not opened with bad creation mod set (which is a bad thing)\n");
+		return -1;
 	}
 	else {
-		printf(" file opened with bad mode.(which is a bad thing)\n");
-		return -1;
+		/* file opened */
+		return 1;
 	}
-	/* the program should not get here but the compiler is complaining */
-	return -1;
+
 }
 int test_yaffs_open_EINVAL2_clean(void){
 	if (handle >=0){
diff --git a/direct/yaffsfs.c b/direct/yaffsfs.c
index 41d37f4..aa8d74d 100644
--- a/direct/yaffsfs.c
+++ b/direct/yaffsfs.c
@@ -1821,7 +1821,7 @@ int yaffs_mount2(const YCHAR *path,int read_only)
 	int retVal=-1;
 	int result=YAFFS_FAIL;
 	struct yaffs_dev *dev=NULL;
-	YCHAR *dummy;
+	YCHAR *restOfPath;
 
 	T(YAFFS_TRACE_MOUNT,(TSTR("yaffs: Mounting %s" TENDSTR),path));
 
@@ -1829,8 +1829,8 @@ int yaffs_mount2(const YCHAR *path,int read_only)
 
 	yaffsfs_InitHandles();
 
-	dev = yaffsfs_FindDevice(path,&dummy);
-	if(dev){
+	dev = yaffsfs_FindDevice(path,&restOfPath);
+	if(dev && !(*restOfPath)){
 		if(!dev->is_mounted){
 			dev->read_only = read_only ? 1 : 0;
 			result = yaffs_guts_initialise(dev);