From: Charles Manning <cdhmanning@gmail.com>
Date: Wed, 19 Jan 2011 22:35:08 +0000 (+1300)
Subject: yaffs: Fix NULL check sequence.
X-Git-Tag: linux-mainline-patchset-5~2^2~8
X-Git-Url: http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=commitdiff_plain;h=2621bcf7c81e3add56dc18c49177c5572d358f4a

yaffs: Fix NULL check sequence.

Potential NULL dreference before check.
Picked up by Coverity check.

Signed-off-by: Charles Manning <cdhmanning@gmail.com>
---

diff --git a/yaffs_guts.c b/yaffs_guts.c
index a579eee..496cf5f 100644
--- a/yaffs_guts.c
+++ b/yaffs_guts.c
@@ -1640,15 +1640,15 @@ static void yaffs_unhash_obj(struct yaffs_obj *obj)
 /*  FreeObject frees up a Object and puts it back on the free list */
 static void yaffs_free_obj(struct yaffs_obj *obj)
 {
-	struct yaffs_dev *dev = obj->my_dev;
-
-	yaffs_trace(YAFFS_TRACE_OS, "FreeObject %p inode %p",
-		obj, obj->my_inode);
+	struct yaffs_dev *dev;
 
 	if (!obj) {
 		YBUG();
 		return;
 	}
+	dev = obj->my_dev;
+	yaffs_trace(YAFFS_TRACE_OS, "FreeObject %p inode %p",
+		obj, obj->my_inode);
 	if (obj->parent)
 		YBUG();
 	if (!list_empty(&obj->siblings))