From: Timothy Manning <tfhmanning@gmail.com>
Date: Wed, 17 Nov 2010 02:31:12 +0000 (+1300)
Subject: yaffs Found the bug.
X-Git-Tag: linux-mainline-patchset-4~76
X-Git-Url: http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=commitdiff_plain;h=fc8b640f9637823d87b9582c7edcb87adcd0383a

yaffs Found the bug.
Signed-off-by: Timothy Manning <tfhmanning@gmail.com>
---

diff --git a/direct/timothy_tests/quick_tests/quick_tests.c b/direct/timothy_tests/quick_tests/quick_tests.c
index 115525b..9fcc037 100644
--- a/direct/timothy_tests/quick_tests/quick_tests.c
+++ b/direct/timothy_tests/quick_tests/quick_tests.c
@@ -35,10 +35,6 @@ int main(int argc, char *argv[]){
 	print_message("\n\nrunning quick tests for yaffs\n\n", 0);
 
 	for (x=0;x<total_number_of_tests;x++){
-		output=test_yaffs_open();
-		printf("yaffs_open = %d\n",output);
-		printf("yaffs_close handle 0 = %d\n",yaffs_close(output));
-		//printf("yaffs_close handle 1#################################### =%d\n",yaffs_close(1));
 		yaffs_set_error(0);	/*reset the last error to 0 */
 		sprintf(message,"\nrunning test: %s \n",test_list[x].name_of_test);
 		print_message(message,3);
diff --git a/direct/timothy_tests/quick_tests/test_yaffs_mount2.c b/direct/timothy_tests/quick_tests/test_yaffs_mount2.c
index 52728b7..8bf856d 100644
--- a/direct/timothy_tests/quick_tests/test_yaffs_mount2.c
+++ b/direct/timothy_tests/quick_tests/test_yaffs_mount2.c
@@ -16,7 +16,6 @@
 int test_yaffs_mount2(void)
 {
 	int output = -1;
-	printf("closing handle again %d\n",yaffs_close(0));
 	output= yaffs_unmount(YAFFS_MOUNT_POINT);
 	if (output < 0) {
 		print_message("failed to unmount current_mountpoint\n",2);
diff --git a/direct/timothy_tests/quick_tests/test_yaffs_mount_ENODEV.c b/direct/timothy_tests/quick_tests/test_yaffs_mount_ENODEV.c
index 2688860..f073d20 100644
--- a/direct/timothy_tests/quick_tests/test_yaffs_mount_ENODEV.c
+++ b/direct/timothy_tests/quick_tests/test_yaffs_mount_ENODEV.c
@@ -13,15 +13,15 @@
 
 #include "test_yaffs_mount_ENODEV.h"
 
-static int handle = 0;
+
 
 int test_yaffs_mount_ENODEV(void)
 {
 	int output=0;
 	int error_code=0;
 
-	handle = yaffs_mount("/nonexisting_mount_point/");
-	if (handle==-1){
+	output = yaffs_mount("/nonexisting_mount_point/");
+	if (output<0){
 		error_code = yaffs_get_error();
 		if (abs(error_code) == ENODEV){
 			return 1;
@@ -29,7 +29,7 @@ int test_yaffs_mount_ENODEV(void)
 			print_message("different error than expected\n",2);
 			return -1;
 		}
-	} else if (output >=0){
+	} else {
 		print_message("non existant directory opened.(which is a bad thing)\n",2);
 		return -1;
 	}
diff --git a/direct/timothy_tests/quick_tests/test_yaffs_read_EINVAL.c b/direct/timothy_tests/quick_tests/test_yaffs_read_EINVAL.c
index 27120b2..57f47fb 100644
--- a/direct/timothy_tests/quick_tests/test_yaffs_read_EINVAL.c
+++ b/direct/timothy_tests/quick_tests/test_yaffs_read_EINVAL.c
@@ -20,7 +20,6 @@ int test_yaffs_read_EINVAL(void)
 {
 	int error_code = 0;
 	handle=yaffs_open(FILE_PATH,O_CREAT | O_RDWR, FILE_MODE);
-	printf("newly opend handle = %d handle\n",handle);
 	char text[2000000]="\0";
 	int output=0;	
 	
@@ -86,7 +85,6 @@ int test_yaffs_read_EINVAL_clean(void)
 		if(output>=0){
 			output=yaffs_close(handle);
 			if (output>=0){
-				printf("closed the file, handle %d\n",handle);
 				return 1;
 			} else {
 				print_message("could not close the handle\n",2);