Better retirement and erasure checking.
[yaffs2.git] / yaffs_guts.c
index 8b7ccc32ede7540f60bae1d385aac79c2347145d..db476089e44d59e72a6e0bfb46a6e7a498721b5e 100644 (file)
@@ -13,7 +13,7 @@
  */
 
 const char *yaffs_guts_c_version =
-    "$Id: yaffs_guts.c,v 1.33 2006-05-17 09:20:26 charles Exp $";
+    "$Id: yaffs_guts.c,v 1.37 2006-09-21 08:13:59 charles Exp $";
 
 #include "yportenv.h"
 
@@ -22,6 +22,9 @@ const char *yaffs_guts_c_version =
 #include "yaffs_tagsvalidity.h"
 
 #include "yaffs_tagscompat.h"
+#ifndef CONFIG_YAFFS_OWN_SORT
+#include "yaffs_qsort.h"
+#endif
 #include "yaffs_nand.h"
 
 #include "yaffs_checkptrw.h"
@@ -41,7 +44,7 @@ void yfsd_UnlockYAFFS(BOOL fsLockOnly);
 
 /* Robustification (if it ever comes about...) */
 static void yaffs_RetireBlock(yaffs_Device * dev, int blockInNAND);
-static void yaffs_HandleWriteChunkError(yaffs_Device * dev, int chunkInNAND);
+static void yaffs_HandleWriteChunkError(yaffs_Device * dev, int chunkInNAND, int erasedOk);
 static void yaffs_HandleWriteChunkOk(yaffs_Device * dev, int chunkInNAND,
                                     const __u8 * data,
                                     const yaffs_ExtendedTags * tags);
@@ -50,6 +53,7 @@ static void yaffs_HandleUpdateChunk(yaffs_Device * dev, int chunkInNAND,
 
 /* Other local prototypes */
 static int yaffs_UnlinkObject( yaffs_Object *obj);
+static int yaffs_ObjectHasCachedWriteData(yaffs_Object *obj);
 
 static void yaffs_HardlinkFixup(yaffs_Device *dev, yaffs_Object *hardList);
 
@@ -89,7 +93,7 @@ static int yaffs_TagsMatch(const yaffs_ExtendedTags * tags, int objectId,
 
 loff_t yaffs_GetFileSize(yaffs_Object * obj);
 
-static int yaffs_AllocateChunk(yaffs_Device * dev, int useReserve);
+static int yaffs_AllocateChunk(yaffs_Device * dev, int useReserve, yaffs_BlockInfo **blockUsedPtr);
 
 static void yaffs_VerifyFreeChunks(yaffs_Device * dev);
 
@@ -165,6 +169,32 @@ static void yaffs_ReleaseTempBuffer(yaffs_Device * dev, __u8 * buffer,
 
 }
 
+/*
+ * Determine if we have a managed buffer.
+ */
+int yaffs_IsManagedTempBuffer(yaffs_Device * dev, const __u8 * buffer)
+{
+       int i;
+       for (i = 0; i < YAFFS_N_TEMP_BUFFERS; i++) {
+               if (dev->tempBuffer[i].buffer == buffer)
+                       return 1;
+
+       }
+
+    for (i = 0; i < dev->nShortOpCaches; i++) {
+        if( dev->srCache[i].data == buffer )
+            return 1;
+
+    }
+
+    if (buffer == dev->checkpointBuffer)
+      return 1;
+
+    T(YAFFS_TRACE_ALWAYS,
+         (TSTR("yaffs: unmaged buffer detected.\n" TENDSTR)));
+    return 0;
+}
+
 /*
  * Chunk bitmap manipulations
  */
@@ -269,6 +299,10 @@ static int yaffs_CheckChunkErased(struct yaffs_DeviceStruct *dev,
        yaffs_ExtendedTags tags;
 
        yaffs_ReadChunkWithTagsFromNAND(dev, chunkInNAND, data, &tags);
+       
+       if(tags.eccResult > YAFFS_ECC_RESULT_NO_ERROR)
+               retval = YAFFS_FAIL;
+               
 
        if (!yaffs_CheckFF(data, dev->nBytesPerChunk) || tags.chunkUsed) {
                T(YAFFS_TRACE_NANDACCESS,
@@ -289,21 +323,46 @@ static int yaffs_WriteNewChunkWithTagsToNAND(struct yaffs_DeviceStruct *dev,
 {
        int chunk;
 
-       int writeOk = 1;
+       int writeOk = 0;
+       int erasedOk = 1;
        int attempts = 0;
+       yaffs_BlockInfo *bi;
        
        yaffs_InvalidateCheckpoint(dev);
 
        do {
-               chunk = yaffs_AllocateChunk(dev, useReserve);
+               chunk = yaffs_AllocateChunk(dev, useReserve,&bi);
 
                if (chunk >= 0) {
-
-                       /* First check this chunk is erased... */
-#ifndef CONFIG_YAFFS_DISABLE_CHUNK_ERASED_CHECK
-                       writeOk = yaffs_CheckChunkErased(dev, chunk);
+                       /* First check this chunk is erased, if it needs checking.
+                        * The checking policy (unless forced always on) is as follows:
+                        * Check the first page we try to write in a block.
+                        * - If the check passes then we don't need to check any more.
+                        * - If the check fails, we check again...
+                        * If the block has been erased, we don't need to check.
+                        *
+                        * However, if the block has been prioritised for gc, then
+                        * we think there might be something odd about this block
+                        * and should continue doing erased checks.
+                        *
+                        * Rationale:
+                        * We should only ever see chunks that have not been erased
+                        * if there was a partially written chunk due to power loss
+                        * This checking policy should catch that case with very
+                        * few checks and thus save a lot of checks that are most likely not
+                        * needed.
+                        */
+                        
+#ifdef CONFIG_YAFFS_ALWAYS_CHECK_CHUNK_ERASED
+                       bi->skipErasedCheck = 1;
 #endif
-                       if (!writeOk) {
+                       if(!bi->skipErasedCheck){
+                               erasedOk = yaffs_CheckChunkErased(dev, chunk);
+                               if(erasedOk && !bi->gcPrioritise)
+                                       bi->skipErasedCheck = 1;
+                       }
+
+                       if (!erasedOk) {
                                T(YAFFS_TRACE_ERROR,
                                  (TSTR
                                   ("**>> yaffs chunk %d was not erased"
@@ -313,6 +372,7 @@ static int yaffs_WriteNewChunkWithTagsToNAND(struct yaffs_DeviceStruct *dev,
                                    yaffs_WriteChunkWithTagsToNAND(dev, chunk,
                                                                   data, tags);
                        }
+                       
                        attempts++;
 
                        if (writeOk) {
@@ -321,10 +381,11 @@ static int yaffs_WriteNewChunkWithTagsToNAND(struct yaffs_DeviceStruct *dev,
                                 *  NB We do this at the end to prevent duplicates in the case of a write error.
                                 *  Todo
                                 */
-                               yaffs_HandleWriteChunkOk(dev, chunk, data,
-                                                        tags);
+                               yaffs_HandleWriteChunkOk(dev, chunk, data, tags);
+                               
                        } else {
-                               yaffs_HandleWriteChunkError(dev, chunk);
+                               /* The erased check or write failed */
+                               yaffs_HandleWriteChunkError(dev, chunk, erasedOk);
                        }
                }
 
@@ -373,12 +434,19 @@ static void yaffs_HandleUpdateChunk(yaffs_Device * dev, int chunkInNAND,
 {
 }
 
-static void yaffs_HandleWriteChunkError(yaffs_Device * dev, int chunkInNAND)
+static void yaffs_HandleWriteChunkError(yaffs_Device * dev, int chunkInNAND, int erasedOk)
 {
+
        int blockInNAND = chunkInNAND / dev->nChunksPerBlock;
+       yaffs_BlockInfo *bi = yaffs_GetBlockInfo(dev, blockInNAND);
+       bi->gcPrioritise = 1;
+       
+       if(erasedOk) {
+               /* Was an actual write failure, so mark the block for retirement  */
 
-       /* Mark the block for retirement */
-       yaffs_GetBlockInfo(dev, blockInNAND)->needsRetiring = 1;
+               bi->needsRetiring = 1;
+       }
+       
        /* Delete the chunk */
        yaffs_DeleteChunk(dev, chunkInNAND, 1, __LINE__);
 }
@@ -1722,6 +1790,15 @@ int yaffs_RenameObject(yaffs_Object * oldDir, const YCHAR * oldName,
 #endif
 
        obj = yaffs_FindObjectByName(oldDir, oldName);
+       /* Check new name to long. */
+       if (obj->variantType == YAFFS_OBJECT_TYPE_SYMLINK &&
+           yaffs_strlen(newName) > YAFFS_MAX_ALIAS_LENGTH)
+         /* ENAMETOOLONG */
+         return YAFFS_FAIL;
+       else if (obj->variantType != YAFFS_OBJECT_TYPE_SYMLINK &&
+                yaffs_strlen(newName) > YAFFS_MAX_NAME_LENGTH)
+         /* ENAMETOOLONG */
+         return YAFFS_FAIL;
 
        if (obj && obj->renameAllowed) {
 
@@ -1856,6 +1933,7 @@ static int yaffs_FindBlockForGarbageCollection(yaffs_Device * dev,
        int iterations;
        int dirtiest = -1;
        int pagesInUse;
+       int prioritised;
        yaffs_BlockInfo *bi;
        static int nonAggressiveSkip = 0;
 
@@ -1886,7 +1964,7 @@ static int yaffs_FindBlockForGarbageCollection(yaffs_Device * dev,
                }
        }
 
-       for (i = 0; i <= iterations && pagesInUse > 0; i++) {
+       for (i = 0, prioritised = 0; i <= iterations && pagesInUse > 0 && !prioritised; i++) {
                b++;
                if (b < dev->internalStartBlock || b > dev->internalEndBlock) {
                        b = dev->internalStartBlock;
@@ -1909,10 +1987,12 @@ static int yaffs_FindBlockForGarbageCollection(yaffs_Device * dev,
 #endif
 
                if (bi->blockState == YAFFS_BLOCK_STATE_FULL &&
-                     (bi->pagesInUse - bi->softDeletions) < pagesInUse &&
+                     (bi->gcPrioritise || (bi->pagesInUse - bi->softDeletions)) < pagesInUse &&
                        yaffs_BlockNotDisqualifiedFromGC(dev, bi)) {
                        dirtiest = b;
                        pagesInUse = (bi->pagesInUse - bi->softDeletions);
+                       if(bi->gcPrioritise)
+                               prioritised = 1; /* Trick it into selecting this one */
                }
        }
 
@@ -1920,8 +2000,8 @@ static int yaffs_FindBlockForGarbageCollection(yaffs_Device * dev,
 
        if (dirtiest > 0) {
                T(YAFFS_TRACE_GC,
-                 (TSTR("GC Selected block %d with %d free" TENDSTR), dirtiest,
-                  dev->nChunksPerBlock - pagesInUse));
+                 (TSTR("GC Selected block %d with %d free, prioritised:%d" TENDSTR), dirtiest,
+                  dev->nChunksPerBlock - pagesInUse,prioritised));
        }
 
        dev->oldestDirtySequence = 0;
@@ -1974,6 +2054,8 @@ static void yaffs_BlockBecameDirty(yaffs_Device * dev, int blockNo)
                bi->pagesInUse = 0;
                bi->softDeletions = 0;
                bi->hasShrinkHeader = 0;
+               bi->skipErasedCheck = 1;  /* This is clean, so no need to check */
+               bi->gcPrioritise = 0;
                yaffs_ClearChunkBits(dev, blockNo);
 
                T(YAFFS_TRACE_ERASE,
@@ -2053,7 +2135,7 @@ static int yaffs_CheckSpaceForAllocation(yaffs_Device * dev)
        return (dev->nFreeChunks > reservedChunks);
 }
 
-static int yaffs_AllocateChunk(yaffs_Device * dev, int useReserve)
+static int yaffs_AllocateChunk(yaffs_Device * dev, int useReserve, yaffs_BlockInfo **blockUsedPtr)
 {
        int retVal;
        yaffs_BlockInfo *bi;
@@ -2094,6 +2176,9 @@ static int yaffs_AllocateChunk(yaffs_Device * dev, int useReserve)
                        dev->allocationBlock = -1;
                }
 
+               if(blockUsedPtr)
+                       *blockUsedPtr = bi;
+                       
                return retVal;
        }
        
@@ -2336,6 +2421,8 @@ static int yaffs_CheckGarbageCollection(yaffs_Device * dev)
        int aggressive;
        int gcOk = YAFFS_OK;
        int maxTries = 0;
+       
+       int checkpointBlockAdjust;
 
        if (dev->isDoingGC) {
                /* Bail out so we don't get recursive gc */
@@ -2348,7 +2435,12 @@ static int yaffs_CheckGarbageCollection(yaffs_Device * dev)
 
        do {
                maxTries++;
-               if (dev->nErasedBlocks < dev->nReservedBlocks) {
+               
+               checkpointBlockAdjust = (dev->nCheckpointReservedBlocks - dev->blocksInCheckpoint);
+               if(checkpointBlockAdjust < 0)
+                       checkpointBlockAdjust = 0;
+
+               if (dev->nErasedBlocks < (dev->nReservedBlocks + checkpointBlockAdjust)) {
                        /* We need a block soon...*/
                        aggressive = 1;
                } else {
@@ -2909,7 +3001,8 @@ int yaffs_UpdateObjectHeader(yaffs_Object * in, const YCHAR * name, int force,
                                                  __LINE__);
                        }
 
-                       in->dirty = 0;
+                       if(!yaffs_ObjectHasCachedWriteData(in))
+                               in->dirty = 0;
 
                        /* If this was a shrink, then mark the block that the chunk lives on */
                        if (isShrink) {
@@ -2943,6 +3036,25 @@ int yaffs_UpdateObjectHeader(yaffs_Object * in, const YCHAR * name, int force,
  *   need a very intelligent search.
  */
 
+static int yaffs_ObjectHasCachedWriteData(yaffs_Object *obj)
+{
+       yaffs_Device *dev = obj->myDev;
+       int i;
+       yaffs_ChunkCache *cache;
+       int nCaches = obj->myDev->nShortOpCaches;
+       
+       if(nCaches > 0){
+               for(i = 0; i < nCaches; i++){
+                       if (dev->srCache[i].object == obj &&
+                                   dev->srCache[i].dirty)
+                                       return 1;
+               }
+       }
+       
+       return 0;
+}
+
+
 static void yaffs_FlushFilesChunkCache(yaffs_Object * obj)
 {
        yaffs_Device *dev = obj->myDev;
@@ -3382,13 +3494,15 @@ static int yaffs_CheckpointTnodeWorker(yaffs_Object * in, yaffs_Tnode * tn,
 {
        int i;
        yaffs_Device *dev = in->myDev;
+       int ok = 1;
+       int nTnodeBytes = (dev->tnodeWidth * YAFFS_NTNODES_LEVEL0)/8;
 
        if (tn) {
                if (level > 0) {
 
-                       for (i = 0; i < YAFFS_NTNODES_INTERNAL; i++){
+                       for (i = 0; i < YAFFS_NTNODES_INTERNAL && ok; i++){
                                if (tn->internal[i]) {
-                                       yaffs_CheckpointTnodeWorker(in,
+                                       ok = yaffs_CheckpointTnodeWorker(in,
                                                        tn->internal[i],
                                                        level - 1,
                                                        (chunkOffset<<YAFFS_TNODES_INTERNAL_BITS) + i);
@@ -3397,12 +3511,13 @@ static int yaffs_CheckpointTnodeWorker(yaffs_Object * in, yaffs_Tnode * tn,
                } else if (level == 0) {
                        __u32 baseOffset = chunkOffset <<  YAFFS_TNODES_LEVEL0_BITS;
                        /* printf("write tnode at %d\n",baseOffset); */
-                       yaffs_CheckpointWrite(dev,&baseOffset,sizeof(baseOffset));
-                       yaffs_CheckpointWrite(dev,tn,(dev->tnodeWidth * YAFFS_NTNODES_LEVEL0)/8);
+                       ok = (yaffs_CheckpointWrite(dev,&baseOffset,sizeof(baseOffset)) == sizeof(baseOffset));
+                       if(ok)
+                               ok = (yaffs_CheckpointWrite(dev,tn,nTnodeBytes) == nTnodeBytes);
                }
        }
 
-       return 1;
+       return ok;
 
 }
 
@@ -3519,13 +3634,14 @@ static int yaffs_ReadCheckpointObjects(yaffs_Device *dev)
                        
                if(ok && cp.objectId == ~0)
                        done = 1;
-               else {
-                       /* printf("Read object %d type %d\n",cp.objectId,cp.variantType); */
+               else if(ok){
+                       T(YAFFS_TRACE_CHECKPOINT,(TSTR("Read object %d parent %d type %d" TENDSTR),
+                               cp.objectId,cp.parentId,cp.variantType));
                        obj = yaffs_FindOrCreateObjectByNumber(dev,cp.objectId, cp.variantType);
                        if(obj) {
                                yaffs_CheckpointObjectToObject(obj,&cp);
                                if(obj->variantType == YAFFS_OBJECT_TYPE_FILE) {
-                                       yaffs_ReadCheckpointTnodes(obj);
+                                       ok = yaffs_ReadCheckpointTnodes(obj);
                                } else if(obj->variantType == YAFFS_OBJECT_TYPE_HARDLINK) {
                                        obj->hardLinks.next =
                                                    (struct list_head *)
@@ -3559,12 +3675,13 @@ static int yaffs_WriteCheckpointData(yaffs_Device *dev)
        if(ok)
                ok = yaffs_WriteCheckpointValidityMarker(dev,0);
                
-       yaffs_CheckpointClose(dev);
-               
-//     if(dev->checkpointBytes)
+       if(!yaffs_CheckpointClose(dev))
+                ok = 0;
+                
+       if(ok)
                dev->isCheckpointed = 1;
-//      else 
-               //dev->isCheckpointed = 0;
+        else 
+               dev->isCheckpointed = 0;
 
        return dev->isCheckpointed;
 }
@@ -3586,12 +3703,13 @@ static int yaffs_ReadCheckpointData(yaffs_Device *dev)
                
 
 
-       yaffs_CheckpointClose(dev);
+       if(!yaffs_CheckpointClose(dev))
+               ok = 0;
 
-//     if(ok)
+       if(ok)
                dev->isCheckpointed = 1;
-//      else 
-//             dev->isCheckpointed = 0;
+        else 
+               dev->isCheckpointed = 0;
 
        return ok ? 1 : 0;
 
@@ -3599,7 +3717,8 @@ static int yaffs_ReadCheckpointData(yaffs_Device *dev)
 
 static void yaffs_InvalidateCheckpoint(yaffs_Device *dev)
 {
-       if(dev->isCheckpointed){
+       if(dev->isCheckpointed || 
+          dev->blocksInCheckpoint > 0){
                dev->isCheckpointed = 0;
                yaffs_CheckpointInvalidateStream(dev);
                if(dev->superBlock && dev->markSuperBlockDirty)
@@ -3610,16 +3729,26 @@ static void yaffs_InvalidateCheckpoint(yaffs_Device *dev)
 
 int yaffs_CheckpointSave(yaffs_Device *dev)
 {
+       T(YAFFS_TRACE_CHECKPOINT,(TSTR("save entry: isCheckpointed %d"TENDSTR),dev->isCheckpointed));
+
        if(!dev->isCheckpointed)
                yaffs_WriteCheckpointData(dev);
        
+       T(YAFFS_TRACE_CHECKPOINT,(TSTR("save exit: isCheckpointed %d"TENDSTR),dev->isCheckpointed));
+
        return dev->isCheckpointed;
 }
 
 int yaffs_CheckpointRestore(yaffs_Device *dev)
 {
+       int retval;
+       T(YAFFS_TRACE_CHECKPOINT,(TSTR("restore entry: isCheckpointed %d"TENDSTR),dev->isCheckpointed));
+       
+       retval = yaffs_ReadCheckpointData(dev);
+
+       T(YAFFS_TRACE_CHECKPOINT,(TSTR("restore exit: isCheckpointed %d"TENDSTR),dev->isCheckpointed));
        
-       return yaffs_ReadCheckpointData(dev);
+       return retval;
 }
 
 /*--------------------- File read/write ------------------------
@@ -4378,6 +4507,18 @@ static void yaffs_HardlinkFixup(yaffs_Device *dev, yaffs_Object *hardList)
 
 
 
+static int ybicmp(const void *a, const void *b){
+    register int aseq = ((yaffs_BlockIndex *)a)->seq;
+    register int bseq = ((yaffs_BlockIndex *)b)->seq;
+    register int ablock = ((yaffs_BlockIndex *)a)->block;
+    register int bblock = ((yaffs_BlockIndex *)b)->block;
+    if( aseq == bseq )
+        return ablock - bblock;
+    else
+        return aseq - bseq;
+
+}
+
 static int yaffs_Scan(yaffs_Device * dev)
 {
        yaffs_ExtendedTags tags;
@@ -4404,6 +4545,14 @@ static int yaffs_Scan(yaffs_Device * dev)
 
        yaffs_BlockIndex *blockIndex = NULL;
 
+       if (dev->isYaffs2) {
+               T(YAFFS_TRACE_SCAN,
+                 (TSTR("yaffs_Scan is not for YAFFS2!" TENDSTR)));
+               return YAFFS_FAIL;
+       }
+       
+       //TODO  Throw all the yaffs2 stuuf out of yaffs_Scan since it is only for yaffs1 format.
+       
        T(YAFFS_TRACE_SCAN,
          (TSTR("yaffs_Scan starts  intstartblk %d intendblk %d..." TENDSTR),
           dev->internalStartBlock, dev->internalEndBlock));
@@ -4925,10 +5074,12 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
        
        int fileSize;
        int isShrink;
+       int foundChunksInBlock;
        int equivalentObjectId;
        
 
        yaffs_BlockIndex *blockIndex = NULL;
+       int altBlockIndex = 0;
 
        if (!dev->isYaffs2) {
                T(YAFFS_TRACE_SCAN,
@@ -4941,11 +5092,23 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
           ("yaffs_ScanBackwards starts  intstartblk %d intendblk %d..."
            TENDSTR), dev->internalStartBlock, dev->internalEndBlock));
 
-       chunkData = yaffs_GetTempBuffer(dev, __LINE__);
 
        dev->sequenceNumber = YAFFS_LOWEST_SEQUENCE_NUMBER;
 
        blockIndex = YMALLOC(nBlocks * sizeof(yaffs_BlockIndex));
+       
+       if(!blockIndex) {
+               blockIndex = YMALLOC_ALT(nBlocks * sizeof(yaffs_BlockIndex));
+               altBlockIndex = 1;
+       }
+       
+       if(!blockIndex) {
+               T(YAFFS_TRACE_SCAN,
+                 (TSTR("yaffs_Scan() could not allocate block index!" TENDSTR)));
+               return YAFFS_FAIL;
+       }
+       
+       chunkData = yaffs_GetTempBuffer(dev, __LINE__);
 
        /* Scan all the blocks to determine their state */
        for (blk = dev->internalStartBlock; blk <= dev->internalEndBlock; blk++) {
@@ -5004,11 +5167,23 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
                }
        }
 
-       /*
-        * Sort the blocks
-        * Dungy old bubble sort for now...
-        */
+       T(YAFFS_TRACE_SCAN,
+       (TSTR("%d blocks to be sorted..." TENDSTR), nBlocksToScan));
+
+
+
+       YYIELD();
+
+       /* Sort the blocks */
+#ifndef CONFIG_YAFFS_USE_OWN_SORT
+       {
+               /* Use qsort now. */
+               qsort(blockIndex, nBlocksToScan, sizeof(yaffs_BlockIndex), ybicmp);
+       }
+#else
        {
+               /* Dungy old bubble sort... */
+               
                yaffs_BlockIndex temp;
                int i;
                int j;
@@ -5021,6 +5196,11 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
                                        blockIndex[i] = temp;
                                }
        }
+#endif
+
+       YYIELD();
+
+       T(YAFFS_TRACE_SCAN, (TSTR("...done" TENDSTR)));
 
        /* Now scan the blocks looking at the data. */
        startIterator = 0;
@@ -5031,6 +5211,9 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
        /* For each block.... backwards */
        for (blockIterator = endIterator; blockIterator >= startIterator;
             blockIterator--) {
+               /* Cooperative multitasking! This loop can run for so
+                  long that watchdog timers expire. */
+               YYIELD();
 
                /* get the block to scan in the correct order */
                blk = blockIndex[blockIterator].block;
@@ -5041,6 +5224,7 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
                deleted = 0;
 
                /* For each chunk in each block that needs scanning.... */
+               foundChunksInBlock = 0;
                for (c = dev->nChunksPerBlock - 1; c >= 0 &&
                     (state == YAFFS_BLOCK_STATE_NEEDS_SCANNING ||
                      state == YAFFS_BLOCK_STATE_ALLOCATING); c--) {
@@ -5055,11 +5239,20 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
                        /* Let's have a good look at this chunk... */
 
                        if (!tags.chunkUsed) {
-                               // An unassigned chunk in the block
-                               // This means that either the block is empty or 
-                               // this is the one being allocated from
+                               /* An unassigned chunk in the block.
+                                * If there are used chunks after this one, then
+                                * it is a chunk that was skipped due to failing the erased
+                                * check. Just skip it so that it can be deleted.
+                                * But, more typically, We get here when this is an unallocated
+                                * chunk and his means that either the block is empty or 
+                                * this is the one being allocated from
+                                */
 
-                               if (c == 0) {
+                               if(foundChunksInBlock)
+                               {
+                                       /* This is a chunk that was skipped due to failing the erased check */
+                                       
+                               } else if (c == 0) {
                                        /* We're looking at the first chunk in the block so the block is unused */
                                        state = YAFFS_BLOCK_STATE_EMPTY;
                                        dev->nErasedBlocks++;
@@ -5100,9 +5293,11 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
                        } else if (tags.chunkId > 0) {
                                /* chunkId > 0 so it is a data chunk... */
                                unsigned int endpos;
-
                                __u32 chunkBase =
                                    (tags.chunkId - 1) * dev->nBytesPerChunk;
+                                                               
+                               foundChunksInBlock = 1;
+
 
                                yaffs_SetChunkBit(dev, blk, c);
                                bi->pagesInUse++;
@@ -5146,6 +5341,8 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
                                /* chunkId == 0, so it is an ObjectHeader.
                                 * Thus, we read in the object header and make the object
                                 */
+                               foundChunksInBlock = 1;
+
                                yaffs_SetChunkBit(dev, blk, c);
                                bi->pagesInUse++;
 
@@ -5450,9 +5647,11 @@ static int yaffs_ScanBackwards(yaffs_Device * dev)
 
        }
 
-       if (blockIndex) {
+       if (altBlockIndex) 
+               YFREE_ALT(blockIndex);
+       else
                YFREE(blockIndex);
-       }
+       
        /* Ok, we've done all the scanning.
         * Fix up the hard link chains.
         * We should now have scanned all the objects, now it's time to add these 
@@ -6074,7 +6273,7 @@ int yaffs_GutsInitialise(yaffs_Device * dev)
                for (i = 0; i < YAFFS_N_TEMP_BUFFERS; i++) {
                        dev->tempBuffer[i].line = 0;    /* not in use */
                        dev->tempBuffer[i].buffer =
-                           YMALLOC(dev->nBytesPerChunk);
+                           YMALLOC_DMA(dev->nBytesPerChunk);
                }
        }
        
@@ -6092,7 +6291,7 @@ int yaffs_GutsInitialise(yaffs_Device * dev)
                        dev->srCache[i].object = NULL;
                        dev->srCache[i].lastUse = 0;
                        dev->srCache[i].dirty = 0;
-                       dev->srCache[i].data = YMALLOC(dev->nBytesPerChunk);
+                       dev->srCache[i].data = YMALLOC_DMA(dev->nBytesPerChunk);
                }
                dev->srLastUse = 0;
        }