Re: [Yaffs] yaffs with kernel 2.6.26: no put_inode()

Hi,

On Tue, Jul 22 at 02:58, KOU Hanjun wrote:
> Hi,
>
> Did anybody spend some time in compiling yaffs for 2.6.26?

Not yet, although I'm sure I'll have that pleasure to come.


> The .put_inode member in struct super_operations has been removed in 2.6.26.
>
> Anybody with a patch?

Since the function is just a debug printf in YAFFS and no longer used in
the kernel I think it would be safe to simply delete it. Untested patch
below, let us know how you get on.

--- yaffs_fs.c-orig     2008-07-22 09:21:20.000000000 +0100
+++ yaffs_fs.c  2008-07-22 09:22:03.000000000 +0100
@@ -183,7 +183,6 @@
 #endif
 static void yaffs_read_inode(struct inode *inode);

-static void yaffs_put_inode(struct inode *inode);
static void yaffs_delete_inode(struct inode *);
static void yaffs_clear_inode(struct inode *);

@@ -285,7 +284,6 @@
 static struct super_operations yaffs_super_ops = {
        .statfs = yaffs_statfs,
        .read_inode = yaffs_read_inode,
-       .put_inode = yaffs_put_inode,
        .put_super = yaffs_put_super,
        .delete_inode = yaffs_delete_inode,
        .clear_inode = yaffs_clear_inode,
@@ -429,17 +427,6 @@

}

-/* For now put inode is just for debugging
- * Put inode is called when the inode **structure** is put.
- */
-static void yaffs_put_inode(struct inode *inode)
-{
-       T(YAFFS_TRACE_OS,
-         ("yaffs_put_inode: ino %d, count %d\n", (int)inode->i_ino,
-          atomic_read(&inode->i_count)));
-
-}
-
 /* clear is called to tell the fs to release any per-inode data it holds */
 static void yaffs_clear_inode(struct inode *inode)
 {

-- 
        Bob Dunlop
        Guralp Systems Limited
        http://www.guralp.com