rtems_yaffs: Remove unnecessary flushing of symlink
authorCharles Manning <cdhmanning@gmail.com>
Thu, 12 Mar 2020 23:26:37 +0000 (12:26 +1300)
committerCharles Manning <cdhmanning@gmail.com>
Thu, 12 Mar 2020 23:26:37 +0000 (12:26 +1300)
Flushing only has meaning on regular files which have cached data.
Symlinks do not have any cached data, therefore flushing has no purpose. Remove.

Signed-off-by: Charles Manning <cdhmanning@gmail.com>
rtems/rtems_yaffs.c

index 8ee0b89..4611320 100644 (file)
@@ -684,14 +684,6 @@ static int ryfs_symlink(const rtems_filesystem_location_info_t *parent_loc,
                                                geteuid(), getegid(), target);
 
        if (created_link != NULL) {
-               // In RTEMS VFS, there is no filesytem-wide sync(), only per-file
-               // flushes.  Filesystem-wide sync is implemented by looping over all of
-               // the open files and individually fsync()ing them.  That's part of why
-               // every close() in RTEMS-yaffs is accompanied by an implicit fsync().
-               // There is no such close() call associated with the symlink's creation,
-               // since it wasn't created via open().  Therefore, flush it immediately
-               // instead.
-               yaffs_flush_file(created_link, 0, 0, 0);
                ret = 0;
        } else {
                errno = EINVAL;