yaffs: Fix NULL check sequence.

Potential NULL dreference before check.
Picked up by Coverity check.

Signed-off-by: Charles Manning <cdhmanning@gmail.com>

diff --git a/yaffs_guts.c b/yaffs_guts.c
index a579eee51bbd232e2d4a33630aac7cb1eb5cd165..496cf5fb61938d1a706a5c6d617ba94d1be54c86 100644 (file)
--- a/yaffs_guts.c
+++ b/yaffs_guts.c
@@ -1640,15 +1640,15 @@ static void yaffs_unhash_obj(struct yaffs_obj *obj)
 /*  FreeObject frees up a Object and puts it back on the free list */
 static void yaffs_free_obj(struct yaffs_obj *obj)
 {
-       struct yaffs_dev *dev = obj->my_dev;
-
-       yaffs_trace(YAFFS_TRACE_OS, "FreeObject %p inode %p",
-               obj, obj->my_inode);
+       struct yaffs_dev *dev;
 
        if (!obj) {
                YBUG();
                return;
        }
+       dev = obj->my_dev;
+       yaffs_trace(YAFFS_TRACE_OS, "FreeObject %p inode %p",
+               obj, obj->my_inode);
        if (obj->parent)
                YBUG();
        if (!list_empty(&obj->siblings))